Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pylons - Remove ace_zeus from requiredAddons #6808

Merged
merged 1 commit into from
Feb 11, 2019
Merged

Pylons - Remove ace_zeus from requiredAddons #6808

merged 1 commit into from
Feb 11, 2019

Conversation

PabstMirror
Copy link
Contributor

pylons only needed ace_zeus for EFUNC(zeus,showMessage)
but the only way the function would be called with _isCurator is from ace_zeus
so no need for requiredAddons entry

@PabstMirror PabstMirror added this to the 3.13.0 milestone Feb 11, 2019
654wak654
654wak654 approved these changes Feb 11, 2019
View reviewed changes
Copy link
Contributor

@654wak654 654wak654 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, the wonders of dynamic typing!

@PabstMirror PabstMirror merged commit 1abe622 into master Feb 11, 2019
@PabstMirror PabstMirror deleted the pyZeusRequiredment branch February 11, 2019 20:19
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@PabstMirror
Pylons - Remove ace_zeus from requiredAddons (#6808)
0bbd12f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@654wak654 654wak654 654wak654 approved these changes

Assignees
No one assigned
Labels
impact/trivial
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
2 participants
@PabstMirror @654wak654