Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inventory - Cache inventory postInit config lookups #6803

Merged
merged 7 commits into from
Feb 17, 2019
Merged

Inventory - Cache inventory postInit config lookups #6803

merged 7 commits into from
Feb 17, 2019

Conversation

dedmen
Copy link
Contributor

@dedmen dedmen commented Feb 9, 2019

A picture says more than a thousand words:

@dedmen dedmen force-pushed the inventoryPostInitCache branch from 15ab4cd to 8425689 Compare February 9, 2019 13:10
@dedmen dedmen force-pushed the inventoryPostInitCache branch from f3f1b0a to aee7ee9 Compare February 9, 2019 13:19
@PabstMirror PabstMirror added this to the 3.13.0 milestone Feb 10, 2019
@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Feb 10, 2019
@PabstMirror PabstMirror changed the title Cache inventory postInit config lookups Inventory - Cache inventory postInit config lookups Feb 10, 2019
@PabstMirror PabstMirror added kind/optimization Release Notes: **IMPROVED:** and removed kind/enhancement Release Notes: **IMPROVED:** labels Feb 10, 2019
@jonpas jonpas mentioned this pull request Feb 11, 2019
Closed
@PabstMirror
add parenthesii (not trolling)
7aa1faa 
these are actually needed
```
Error in expression <_inventory_Grenades_ItemList", []];
if (!ace_inventory_Grenades_ItemList isEqual>
  Error position: <!ace_inventory_Grenades_ItemList isEqual>
  Error !: Type Array, expected Bool
```
@PabstMirror
Add space
50e5f7e
@PabstMirror PabstMirror merged commit 21fd4e5 into acemod:master Feb 17, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@dedmen @PabstMirror
Inventory - Cache inventory postInit config lookups (#6803)
0d06fc9 
* Cache inventory postInit config lookups

* Safety

* fix

* More better

* ugh

* add parenthesii (not trolling)

these are actually needed
```
Error in expression <_inventory_Grenades_ItemList", []];
if (!ace_inventory_Grenades_ItemList isEqual>
  Error position: <!ace_inventory_Grenades_ItemList isEqual>
  Error !: Type Array, expected Bool
```

* Add space
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@commy2 commy2 commy2 left review comments

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/optimization Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@dedmen @commy2 @PabstMirror