Common - Use CBA addons instead of activatedAddons #6802
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Does this break anything due to case sensitivity? |
|
We look for |
|
Yes. Also find a3_ is kinda bad. Shouldn't we just select the first 3 characters and compare if it's a3_ or ace? |
|
How about this? |
PabstMirror
reviewed
Feb 10, 2019
PabstMirror
changed the title
PabstMirror
added
kind/enhancement
commy2
reviewed
Feb 12, 2019
commy2
reviewed
Feb 12, 2019
PabstMirror
approved these changes
Feb 13, 2019
jonpas
reviewed
Feb 14, 2019
Co-Authored-By: dedmen <[email protected]>
|
Thanks for making commy happy |
commy2
reviewed
Feb 14, 2019
| } forEach activatedAddons; | ||
| private _aceWhitelist = missionNamespace getVariable ["ACE_Version_Whitelist", []]; | ||
| private _files = CBA_common_addons select { | ||
| (_x select [0,3] != "a3_") && |
There was a problem hiding this comment.
Suggested change
| (_x select [0,3] != "a3_") && | |
| _x select [0,3] != "a3_" && |
commy2
reviewed
Feb 14, 2019
| private _files = CBA_common_addons select { | ||
| (_x select [0,3] != "a3_") && | ||
| {_x select [0,4] != "ace_"} && | ||
| {!((toLower _x) in _aceWhitelist)} |
There was a problem hiding this comment.
Suggested change
| {!((toLower _x) in _aceWhitelist)} | |
| {!(toLower _x in _aceWhitelist)} |
|
Not so fast. |
|
I accidentally merged it before we could apply those changes |
|
boo |
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Use CBA addons instead of activatedAddons * Better checks * Betterest checks * Delay call to toLower until needed * Apply suggestions from code review Co-Authored-By: dedmen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: CBATeam/CBA_A3#1051 (comment)
Related: #6800