Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Medical - Add new setting to hide self-interaction actions #6756

Merged
merged 2 commits into from
Jan 12, 2019
Merged

Medical - Add new setting to hide self-interaction actions #6756

merged 2 commits into from
Jan 12, 2019

Conversation

PabstMirror
Copy link
Contributor

Fix #6735

@PabstMirror PabstMirror added kind/bug-fix Release Notes: **FIXED:** MedicalRewrite-Rectify labels Jan 2, 2019
@PabstMirror PabstMirror added this to the 3.13.0 milestone Jan 2, 2019
alganthe
alganthe requested changes Jan 2, 2019
View reviewed changes
Copy link
Contributor

@alganthe alganthe left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description of the setting needs to be updated, also "disabled" doesn't make sense in this case, maybe change that to "medical menu only" ?

Either that or changing the name of the setting to imply it's only for selections.

@jonpas
Copy link
Member

jonpas commented Jan 2, 2019

also "disabled" doesn't make sense in this case, maybe change that to "medical menu only" ?

Medical menu is a separate setting, you can run both disabled (I think only keybind for medical menu will work then, if even). Disabled is fine in this case, it disables Medical Interactions.

@alganthe
Copy link
Contributor

alganthe commented Jan 2, 2019

yes but the setting is ambiguous.

@PabstMirror PabstMirror changed the title Medical - Hide self interaction menu if disabled Medical - Add new setting to hide self-interaction actions Jan 12, 2019
@PabstMirror PabstMirror merged commit 188aabe into master Jan 12, 2019
@PabstMirror PabstMirror deleted the medSelfMenuHide branch January 12, 2019 02:58
@TheMagnetar TheMagnetar mentioned this pull request Feb 19, 2019
Closed
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@PabstMirror
Medical - Add new setting to hide self-interaction actions (#6756)
62b6463 
* Medical - Hide self interaction menu if disabled

* Add new setting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alganthe alganthe alganthe approved these changes

Assignees
No one assigned
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @jonpas @alganthe