Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeus - Paradrop Cargo #6743

Merged
merged 4 commits into from
Jan 31, 2019
Merged

Zeus - Paradrop Cargo #6743

merged 4 commits into from
Jan 31, 2019

Conversation

PabstMirror
Copy link
Contributor

Zeus can command an aircraft to paradrop cargo at a location

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Dec 21, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Dec 21, 2018
mharis001
mharis001 approved these changes Dec 21, 2018
View reviewed changes
Copy link
Member

@mharis001 mharis001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested in-game, works well. Comments I left are for small cleanup changes.

addons/zeus/functions/fnc_moduleCargoParadrop.sqf Outdated Show resolved Hide resolved
addons/zeus/functions/fnc_moduleCargoParadrop.sqf Outdated Show resolved Hide resolved
addons/zeus/config.cpp Outdated Show resolved Hide resolved
addons/zeus/functions/fnc_moduleCargoParadrop.sqf Outdated Show resolved Hide resolved
@alganthe
Copy link
Contributor

Same thoughts as mharis, tested and works well.

@PabstMirror
Copy link
Contributor Author

I was a little surprised that moving the created waypoint in zeus actually works
Looks like they are modifying the param _wpPos by reference

@PabstMirror PabstMirror merged commit 32ffe32 into master Jan 31, 2019
@PabstMirror PabstMirror deleted the aiParadropCargo branch January 31, 2019 00:30
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@PabstMirror
Zeus - Paradrop Cargo (#6743)
09cad56 
* Zeus - Paradrop Cargo Waypoint

* move script component

* cfgpatches, localize, fix getModuleDestination call

* cleanup debug
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mharis001 mharis001 mharis001 approved these changes

@alganthe alganthe alganthe approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.12.6
Development

Successfully merging this pull request may close these issues.
3 participants
@PabstMirror @alganthe @mharis001