-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ballistics/Realistic Names - Integrate P90 Compat #6667
Conversation
Remove compat? Why not put in fire mode restrictions? They are realistic. |
Wasn't sure about the fire modes, I'll re-add them |
It might make sense to release 1 last dummy compat, so we can delete it after release |
Yeah, TR is the civilian version with long barrel, semi-only. And agreed on keeping compat for a bit longer. |
Add it's magwell in this PR? |
That would be CBA, no? |
lmao, yes, yes, it would. |
@@ -8,6 +8,7 @@ class CfgPatches { | |||
requiredVersion = REQUIRED_VERSION; | |||
requiredAddons[] = { | |||
"A3_Data_F_Tank_Loadorder", | |||
"A3_Data_F_Mod_Loadorder", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this one not require A3_Data_F_Tank_Loadorder
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it seems to just be itself, unless I'm reading it wrong
@PabstMirror don't people get automatically unsubscribed if the mod doesn't exist anymore? Anyone using it on Workshop will get the main ACE3 update anyways at the same time (or rather earlier since we do compats last). |
Very minor (and rather old) issue: Alphabetical sorting in the arsenal puts a variety of Russian weaponry between P90 and PS90. How about adding "FN" to the names? And on the topic of things that should be changed in CBA, the current release on the SWS isn't JointRails compatible. |
Agreed, adding FN would make sense. Doesn't our P90 compat make them joint rails compatible? I thought it did. It should in that case, but side rails are smaller and idk what would fit without adding new rail definition (which would have to be done in CBA). |
Don't see anything in the code, and using the two Workshop mods didn't do it either. Other vanilla weapons get their JR compat in CBA as well: https://github.com/CBATeam/CBA_A3/blob/master/addons/jr/cfgweapons.hpp. I wouldn't be concerned about the pure length of light rails - if anything, combo modules with a white light on the side and a laser on top are more problematic, and are so for other weapons too. Short optics rails should already be a thing. |
Ah cool, guess CBA can add it for next release then if someone wants to PR it. |
Co-Authored-By: PabstMirror <[email protected]>
Co-Authored-By: PabstMirror <[email protected]>
Co-Authored-By: PabstMirror <[email protected]>
Co-Authored-By: PabstMirror <[email protected]>
* Ballistics/Realistic Names - Integrate P90 Compat * Update CfgWeapons.hpp * Remove old compat addon * Update addons/realisticnames/stringtable.xml Co-Authored-By: PabstMirror <[email protected]> * Update addons/realisticnames/CfgWeapons.hpp Co-Authored-By: PabstMirror <[email protected]> * Update addons/ballistics/CfgWeapons.hpp Co-Authored-By: PabstMirror <[email protected]> * Update addons/ballistics/CfgWeapons.hpp Co-Authored-By: PabstMirror <[email protected]>
No description provided.