Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ballistics/Realistic Names - Integrate P90 Compat #6667

Merged
merged 7 commits into from
Dec 3, 2018
Merged

Conversation

PabstMirror
Copy link
Contributor

No description provided.

@jonpas
Copy link
Member

jonpas commented Nov 9, 2018

Remove compat?

Why not put in fire mode restrictions? They are realistic.

@PabstMirror
Copy link
Contributor Author

Wasn't sure about the fire modes, I'll re-add them

@PabstMirror
Copy link
Contributor Author

It might make sense to release 1 last dummy compat, so we can delete it after release
giving more time for people to unsubscribe?

@jonpas
Copy link
Member

jonpas commented Nov 9, 2018

Yeah, TR is the civilian version with long barrel, semi-only.
I don't think this impacts AI, but I am not sure.

And agreed on keeping compat for a bit longer.

@Drofseh
Copy link
Contributor

Drofseh commented Nov 9, 2018

Add it's magwell in this PR?

@jonpas
Copy link
Member

jonpas commented Nov 9, 2018

That would be CBA, no?

@Drofseh
Copy link
Contributor

Drofseh commented Nov 9, 2018

lmao, yes, yes, it would.

addons/ballistics/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/ballistics/CfgWeapons.hpp Outdated Show resolved Hide resolved
@@ -8,6 +8,7 @@ class CfgPatches {
requiredVersion = REQUIRED_VERSION;
requiredAddons[] = {
"A3_Data_F_Tank_Loadorder",
"A3_Data_F_Mod_Loadorder",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this one not require A3_Data_F_Tank_Loadorder?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it seems to just be itself, unless I'm reading it wrong

addons/realisticnames/CfgWeapons.hpp Outdated Show resolved Hide resolved
addons/realisticnames/stringtable.xml Outdated Show resolved Hide resolved
@jonpas
Copy link
Member

jonpas commented Nov 9, 2018

@PabstMirror don't people get automatically unsubscribed if the mod doesn't exist anymore? Anyone using it on Workshop will get the main ACE3 update anyways at the same time (or rather earlier since we do compats last).

@Blutze
Copy link
Contributor

Blutze commented Nov 10, 2018

Very minor (and rather old) issue: Alphabetical sorting in the arsenal puts a variety of Russian weaponry between P90 and PS90. How about adding "FN" to the names?

And on the topic of things that should be changed in CBA, the current release on the SWS isn't JointRails compatible.

@jonpas
Copy link
Member

jonpas commented Nov 10, 2018

Agreed, adding FN would make sense.

Doesn't our P90 compat make them joint rails compatible? I thought it did. It should in that case, but side rails are smaller and idk what would fit without adding new rail definition (which would have to be done in CBA).

@Blutze
Copy link
Contributor

Blutze commented Nov 11, 2018

Doesn't our P90 compat make them joint rails compatible?

Don't see anything in the code, and using the two Workshop mods didn't do it either. Other vanilla weapons get their JR compat in CBA as well: https://github.com/CBATeam/CBA_A3/blob/master/addons/jr/cfgweapons.hpp.

I wouldn't be concerned about the pure length of light rails - if anything, combo modules with a white light on the side and a laser on top are more problematic, and are so for other weapons too. Short optics rails should already be a thing.

@jonpas
Copy link
Member

jonpas commented Nov 11, 2018

Ah cool, guess CBA can add it for next release then if someone wants to PR it.

@jonpas jonpas modified the milestones: Ongoing, 3.13.0 Nov 26, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 27, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.5 Dec 3, 2018
@PabstMirror PabstMirror merged commit 25c10e8 into master Dec 3, 2018
@PabstMirror PabstMirror deleted the 186-p90 branch December 3, 2018 18:03
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Ballistics/Realistic Names - Integrate P90 Compat

* Update CfgWeapons.hpp

* Remove old compat addon

* Update addons/realisticnames/stringtable.xml

Co-Authored-By: PabstMirror <[email protected]>

* Update addons/realisticnames/CfgWeapons.hpp

Co-Authored-By: PabstMirror <[email protected]>

* Update addons/ballistics/CfgWeapons.hpp

Co-Authored-By: PabstMirror <[email protected]>

* Update addons/ballistics/CfgWeapons.hpp

Co-Authored-By: PabstMirror <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants