Nametags - Adjustable colors settings #6641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also made the default colors lighter to make them easier to read
bux
reviewed
Oct 16, 2018
Dystopian
reviewed
Oct 16, 2018
commy2
reviewed
Oct 16, 2018
Dystopian
reviewed
Oct 21, 2018
Dystopian
reviewed
Oct 22, 2018
| } else { | ||
| _color = [[1, 1, 1, _alpha], [1, 0, 0, _alpha], [0, 1, 0, _alpha], [0, 0, 1, _alpha], [1, 1, 0, _alpha]] select ((["MAIN", "RED", "GREEN", "BLUE", "YELLOW"] find ([assignedTeam _target] param [0, "MAIN"])) max 0); | ||
| _color = +([GVAR(nametagColorMain), GVAR(nametagColorRed), GVAR(nametagColorGreen), GVAR(nametagColorBlue), GVAR(nametagColorYellow)] select ((["MAIN", "RED", "GREEN", "BLUE", "YELLOW"] find ([assignedTeam _target] param [0, "MAIN"])) max 0)); |
There was a problem hiding this comment.
could be multi-line
Suggested change
| _color = +([GVAR(nametagColorMain), GVAR(nametagColorRed), GVAR(nametagColorGreen), GVAR(nametagColorBlue), GVAR(nametagColorYellow)] select ((["MAIN", "RED", "GREEN", "BLUE", "YELLOW"] find ([assignedTeam _target] param [0, "MAIN"])) max 0)); | |
| _color = +( | |
| [ | |
| GVAR(nametagColorMain), | |
| GVAR(nametagColorRed), | |
| GVAR(nametagColorGreen), | |
| GVAR(nametagColorBlue), | |
| GVAR(nametagColorYellow) | |
| ] select ( | |
| ( | |
| [ | |
| "MAIN", "RED", "GREEN", "BLUE", "YELLOW" | |
| ] find ( | |
| [assignedTeam _target] param [0, "MAIN"] | |
| ) | |
| ) max 0 | |
| ) | |
| ); |
There was a problem hiding this comment.
Maybe slightly less multiline would be enough. :D
jonpas
added
kind/feature
kind/feature
zharf
force-pushed
the
adjustable_nametag_colors
branch
from
7e8c0d3 to
3004e0e
Compare
PabstMirror
reviewed
Nov 15, 2018
|
|
||
| [ | ||
| QGVAR(nametagColorRed), "COLOR", | ||
| ["str_team_red"], |
There was a problem hiding this comment.
Maybe [format ["%1 %2",localize "str_team", localize "str_team_red"]],
so we get "Team Red"?
There was a problem hiding this comment.
I was considering this but I'm not proficient enough in all the languages to know if the word order for that would be grammatically correct (for Finnish it would be reversed...)
|
Overall looks great and should really help people with color problems |
PabstMirror
changed the title
PabstMirror
approved these changes
Nov 17, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Move hard coded nametag team colors to settings Also made the default colors lighter to make them easier to read * Added myself to contributors * Fixed Nametag to Name Tag * Optimized array copying * Moved team color settings to color subcategory and used vanilla localization strings * Split a long line into a more readable multiline solution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: