Safemode - Fix indicator when switching units #6612
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oh also I removed the todo because that seems to be a leftover from AGM about this exact problem. |
Dystopian
reviewed
Oct 4, 2018
addons/safemode/XEH_postInit.sqf
Outdated
| }, | ||
| {false}, | ||
| [41, [false, true, false]], false] call CBA_fnc_addKeybind; | ||
| }, {false}, [41, [false, true, false]], false] call CBA_fnc_addKeybind; |
There was a problem hiding this comment.
Magic nimber, should be something like DIK_*.
No, it refers to a new unit info display being opened, which has nothing to do with changing the soldier actually. |
|
Okay, so when would that actually happen? I can't find it ever being raised with "Soldier". |
Loading a savegame for example. |
PabstMirror
changed the title
PabstMirror
approved these changes
Oct 27, 2018
BaerMitUmlaut
added a commit
that referenced
this pull request
Aug 5, 2019
* Fix safe mode indicator when switching units * Use DIK macro instead of magic number
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: