UI - Fix selective UI in cargo

[Dystopian]

When merged this pull request will:

• fix Disabling Ammo Count interface - not affect player inside vehicles, if player uses - "this moveInCargo" #6547;
• improve ace_ui_fnc_setAdvancedElement:
  • fix doc;
  • add some debug;
  • fix magic numbers;
  • fix bad variable name (show -> fade).

Maybe now VEHICLE_ONLY and GROUND_ONLY macros should be renamed e.g. to VEHICLE_NOT_CARGO and GROUND_AND_CARGO.

[jonpas]

I don't like fade, it reminds me of slow fading away. Like vanilla option to fade after not being used, and show when needed again. Which is something Selective UI is missing btw.

[Dystopian]

And I don't like show when it means not show. fade is for ctrlSetFade, nothing more.

[commy2]

show and hide

[dedmen]

Why check cargo specifically? Instead of just in vehicle check?

[Dystopian]

because these controls (Soldier/Vehicle/Weapon Information, location = GROUND_ONLY) should be set when on foot or in vehicle cargo including FFV. See also #3877

[dedmen]

Yeah but why cargo? Why exclude driver/gunner?

[Dystopian]

@jonpas should know. I think because that info is shown while player is in cargo and isn't shown when in other seats.

[jonpas]

Why exactly does old way break with moveInCargo?

[Dystopian]

Because ammocount is disabled when player is on foot and not updated when he gets in cargo.
When moveInCargo is used in init, player is never on foot at mission start and ammocount is not disabled because CBA_fnc_canUseWeapon returns false and location == GROUND_ONLY for ammocount.

[Dystopian]

In fact I just added cargo seats to _canUseWeapon condition (on foot and FFV was there) and I had to rename it because _canUseWeapon name became wrong.

[jonpas]

I see, I will test this soon.

[PabstMirror]

Suggested change

	private _isOnFootOrInCargo = isNil "_cargoIndex" || {_cargoIndex > -1};
	private _isOnFootOrInCargo = isNil "_cargoIndex" || {_cargoIndex > -1} || {ACE_player call CBA_fnc_canUseWeapon};

Need this to handle non-cargo FFV turrets.
Example with merkel tank with commander gun,
inside it shows ammo (gunner ammo) fine
turn out and player's gun ammo shows, and exiting while in this state it will continue to show dismounted.

While turned out in turret::
ACE_player call CBA_fnc_canUseWeapon = false
vehicle ACE_player getCargoIndex ACE_player = -1

Could possibly also use isTurnedOut player, but cba func isn't that expensive

[Dystopian]

@PabstMirror I added non-cargo FFV check with variable renaming.

Also I'm not sure now if we should add more location types to config instead such GROUND_ONLY and FFV/cargo combination. Something like GROUND_FFV_CARGO etc.

[PabstMirror]

I guess ground and vehicle aren't perfect, but I think the intent is clear enough
Ground = ground weapons, even if mounted
vehicle = vehicle's own weapons

[jonpas]

I'd prefer this whole thing like this:

if ((_canUseWeaponOrInCargo && {_location == VEHICLE_ONLY}) ||
    {!_canUseWeaponOrInCargo && {_location == GROUND_ONLY}}
) exitWith {
    TRACE_3("skip location",_this,_canUseWeaponOrInCargo,_location);
    false
};

Probably just because I am more used to it, either is mergable.