Add the ability to edit user placed markers #6564
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replace old method of getting the map display with displayParent
|
I like this! Editing markers! |
|
Nice, this is why I love open source. |
bux
reviewed
Sep 6, 2018
| private _mapIDD = -1; | ||
| private _mapDisplay = displayParent _display; | ||
| if (isNull _mapDisplay) exitWith {ERROR("No Map");}; | ||
| private _mapCtrl = _mapDisplay displayctrl 51; |
bux
reviewed
Sep 6, 2018
| if (_mouseOverType isEqualTo "marker") then { | ||
| if !((_marker find "_USER_DEFINED") isEqualTo -1) then { | ||
| GVAR(editingMarker) = _marker; | ||
| //hide marker which is being edited because if the user cancels editing, it will still exits unchanged |
|
@bux Corrected all spelling mistakes (at least those which I could find) |
|
🐝 |
commy2
approved these changes
Sep 6, 2018
Grey-Soldierman
pushed a commit
to Grey-Soldierman/ACE3
that referenced
this pull request
Sep 18, 2018
* add the ability to edit user placed markers * remove direct channel from valid channels * add author * optimize get map display replace old method of getting the map display with displayParent * optimize code by adding isEqualTo * correct some spelling mistakes
|
We might want to disable this for line type markers as they will be converted to a icon, which doesn't make sense to me. |
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* add the ability to edit user placed markers * remove direct channel from valid channels * add author * optimize get map display replace old method of getting the map display with displayParent * optimize code by adding isEqualTo * correct some spelling mistakes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will: