Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Repair - Fix isInRepairFacility for buildings at height #6561

Merged
merged 1 commit into from
Sep 3, 2018

Conversation

PabstMirror
Copy link
Contributor

Fix #6560

On carrier, position player z is 0

@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Sep 3, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Sep 3, 2018
@bux
Copy link
Member

bux commented Sep 3, 2018

Would it make sense to rename the file to fnc_isNearRepairFacility.sqf?

@Dystopian
Copy link
Contributor

@bux it's public

@bux
Copy link
Member

bux commented Sep 3, 2018

@Dystopian I know. We have procedures for such things:

In short: Rename the function, keep the old function name which in turn logs a deprecation warning and just calls the new function.

@Dystopian
Copy link
Contributor

@bux I know 😄
I meant maybe it's not worth it just for renaming. Moreover at Arma EOL.

@commy2
Copy link
Contributor

commy2 commented Sep 3, 2018

nearObjects requires AGL, but position reports AGLS. Could have also used:

ASLToAGL getPosASL _object nearObjects 7.5

but OBJECT is faster.

@commy2 commy2 merged commit 8cd0b49 into master Sep 3, 2018
@commy2 commy2 deleted the repairFacility branch September 3, 2018 16:02
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
Repair - Fix isInRepairFacility for buildings at height
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants