Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastRoping - Add rope items which deploy at lengths #6498

Merged
merged 14 commits into from
Jan 12, 2019

Conversation

pokertour
Copy link
Contributor

When merged this pull request will:

  • I've change the fastroping, by implement 5 items (5 ropes lenght). 5 interaction for each rope lenght.
  • The change is : you have to take with you or in the chopper the rope to be able to Deploy Fastrope.
  • Change :
    -- Create a CfgWeapons.hpp with the 5 differents rope.
    -- Change the CfgVehicles.hpp with the new interaction for each rope lenght.
    -- Change the config.cpp for the CfgWeapons
    -- Change the Stringtables.xml for the new items and interaction text. Need somes translations.
    -- Change the fnc_deployropes.sqf to change the lenght of rope when deploy and remove item when rope has been deployed.
  • Some pictures : http://imgur.com/a/LLqo3
  • i test it on Singleplayer, need some test in multiplayer

@sargken
Copy link
Contributor

sargken commented Aug 10, 2018

Can having the requirement for the rope be optional through the use of a module.

@pokertour
Copy link
Contributor Author

i can add a setting yes

Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the comments that I didn't bunch together in a single review -.-

cheapest check before others
Corrected the double remove.
@thojkooi thojkooi added kind/enhancement Release Notes: **IMPROVED:** status/review-pending labels Nov 19, 2018
@thojkooi thojkooi added this to the 3.13.0 milestone Nov 19, 2018
@thojkooi
Copy link
Contributor

Thanks for your PR. At a quick look this should be fine. Someone from @acemod/maintainers may review this some time soon.

Add setting, move rope len to config, simplify strings, add rope image, fix rope unwind length
@PabstMirror
Copy link
Contributor

Updated PR with a setting for the new feature
with it disabled (default to ensure existing missions are not effected),
the 36m option will always show, and if the player has a custom rope, then those lengths will show as well

@PabstMirror PabstMirror changed the title Changes on FastRoping System FastRoping - Add rope items which deploy at lengths Jan 8, 2019
French translation for settings
@PabstMirror PabstMirror merged commit 4a5b511 into acemod:master Jan 12, 2019
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.6 Feb 23, 2019
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Update stringtable.xml

* Update config.cpp

* New CFGWeapon

* Update CfgVehicles.hpp

* Update fnc_deployRopes.sqf

* Update CfgVehicles.hpp

* Update CfgWeapons.hpp

* Update CfgVehicles.hpp

cheapest check before others

* Update fnc_deployRopes.sqf

Corrected the double remove.

* Cleanup PR

Add setting, move rope len to config, simplify strings, add rope image, fix rope unwind length

* Add setting name to stringtable

* Update stringtable.xml

French translation for settings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants