-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FastRoping - Add rope items which deploy at lengths #6498
Conversation
Can having the requirement for the rope be optional through the use of a module. |
i can add a setting yes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the comments that I didn't bunch together in a single review -.-
cheapest check before others
Corrected the double remove.
Thanks for your PR. At a quick look this should be fine. Someone from @acemod/maintainers may review this some time soon. |
Add setting, move rope len to config, simplify strings, add rope image, fix rope unwind length
Updated PR with a setting for the new feature |
French translation for settings
* Update stringtable.xml * Update config.cpp * New CFGWeapon * Update CfgVehicles.hpp * Update fnc_deployRopes.sqf * Update CfgVehicles.hpp * Update CfgWeapons.hpp * Update CfgVehicles.hpp cheapest check before others * Update fnc_deployRopes.sqf Corrected the double remove. * Cleanup PR Add setting, move rope len to config, simplify strings, add rope image, fix rope unwind length * Add setting name to stringtable * Update stringtable.xml French translation for settings
When merged this pull request will:
-- Create a CfgWeapons.hpp with the 5 differents rope.
-- Change the CfgVehicles.hpp with the new interaction for each rope lenght.
-- Change the config.cpp for the CfgWeapons
-- Change the Stringtables.xml for the new items and interaction text. Need somes translations.
-- Change the fnc_deployropes.sqf to change the lenght of rope when deploy and remove item when rope has been deployed.