Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Strip medical component #6442

Merged
merged 22 commits into from
Jul 18, 2018
Merged

Strip medical component #6442

merged 22 commits into from
Jul 18, 2018

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented Jul 17, 2018

The idea here is to move everything out of medical into its appropriate component of medical (and reserve this component for public functionality only).

@kymckay kymckay added this to the Medical Rewrite milestone Jul 17, 2018
@kymckay
Copy link
Member Author

kymckay commented Jul 18, 2018

Looking at some of the remaining functions in medical:

  • displayTriageCard, the display used by this function is in gui and it makes sense to put this function there too, but there's no call it it anywhere in the code currently
  • addStateHandler, unsure what this is for specifically, there's only one commented out line that uses it in medical_damage
  • setUnconsciousStatemachine, can move this one down to medical_status as it's only used there and in medical_statemachine
  • handleIncapacitation, can move this one down to medical_damage

@kymckay
Copy link
Member Author

kymckay commented Jul 18, 2018

That's the bulk of this component stripped out. We should probably move script_macros_medical.hpp to medical_engine since this component is no longer at the top of the dependency hierarchy

@kymckay
Copy link
Member Author

kymckay commented Jul 18, 2018

Also it seems the paths to textures and stuff in the item p3d's need to be updated to reflect the new location

@kymckay kymckay merged commit 4466f9e into medical-rewrite-restructure Jul 18, 2018
@kymckay kymckay deleted the medical-rw-gut-medical branch July 18, 2018 18:13
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@kymckay
Strip medical component (#6442)
17fb2cb 
* Move litter to `treatment`
* Move eden object attributes to `treatment`
* Move treatment items to `treatment`
* Move bodybag handling to `treatment`
* Move state conditions to `statemachine`
* Move radio addon handling to `feedback`
* Move medical macros to `engine`
* Move medical extension to `damage`
* Fix texture and material paths after move
* Remove duplicate medical menu config
* Remove old faction class
* Remove a bunch of old code
@PabstMirror PabstMirror modified the milestones: Medical Rewrite, 3.13.0 Dec 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thojkooi thojkooi thojkooi approved these changes

Assignees
No one assigned
Labels
area/focus-feature kind/cleanup Release Notes: **CHANGED:**
Projects
ACE3 Medical Focus Feature
Status: Completed
Milestone
3.13.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kymckay @thojkooi @PabstMirror