Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Zeus - UI improvements and additional objects setting for Editable Objects module #6391

Merged
merged 5 commits into from
Sep 13, 2018
Merged

Zeus - UI improvements and additional objects setting for Editable Objects module #6391

merged 5 commits into from
Sep 13, 2018

Conversation

mharis001
Copy link
Member

When merged this pull request will:

  • Add "Additional Objects" setting to Update Editable Objects module
    • Allows for quickly adding units to Zeus without trying to place the module in range or using a large radius
  • Fix Teleport Players UI height and use A3 strings
  • Improve Garrison module UI and capitalize module names
    • Before:
      garrison_ui_old
    • After:
      garrison_ui_new
  • Improve/cleanup Toggle NVGs and Toggle Flashlights UI by adding combo items through config

@mharis001 mharis001 changed the title Zeus - Various UI improvements and additional objects setting for Editable Objects module Zeus - UI improvements and additional objects setting for Editable Objects module Jun 10, 2018
@thojkooi thojkooi added the kind/enhancement Release Notes: **IMPROVED:** label Jul 29, 2018
@thojkooi thojkooi added this to the 3.13.0 milestone Jul 29, 2018
PabstMirror
PabstMirror approved these changes Sep 13, 2018
View reviewed changes
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good

@PabstMirror PabstMirror merged commit d6976f6 into acemod:master Sep 13, 2018
@mharis001 mharis001 deleted the zeus-misc-improvements branch September 13, 2018 15:34
Grey-Soldierman pushed a commit to Grey-Soldierman/ACE3 that referenced this pull request Sep 18, 2018
@mharis001 @Grey-Soldierman
Zeus - UI improvements and additional objects setting for Editable Ob…
ae6e1fb 
…jects module (acemod#6391)

* Add additional objects setting to Editable Objects

* Fix Teleport Players UI height and remove unnecessary strings

* Improve Garrison UI

* Config based combo for Toggle NVG and Toggle Flashlights UI

* Capitalize garrison module names
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.4 Nov 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@mharis001 @PabstMirror
Zeus - UI improvements and additional objects setting for Editable Ob…
f15979e 
…jects module (#6391)

* Add additional objects setting to Editable Objects

* Fix Teleport Players UI height and remove unnecessary strings

* Improve Garrison UI

* Config based combo for Toggle NVG and Toggle Flashlights UI

* Capitalize garrison module names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

Assignees
No one assigned
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Milestone
3.12.4
Development

Successfully merging this pull request may close these issues.
3 participants
@mharis001 @PabstMirror @thojkooi