Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Arsenal - Various additions and fixes #6347

Merged
merged 8 commits into from
May 31, 2018

Conversation

alganthe
Copy link
Contributor

@alganthe alganthe commented May 16, 2018

When merged this pull request will:

  • Add 4 new EHs for the loadouts display:
Name Arguments
ace_arsenal_loadoutsDisplayOpened loadouts screen display (DISPLAY)
ace_arsenal_loadoutsDisplayClosed none
ace_arsenal_loadoutsTabChanged loadouts screen display (DISPLAY), tab control (CONTROL)
ace_arsenal_loadoutsListFilled loadouts screen display (DISPLAY), tab control (CONTROL)
  • Fix the accuracy stat not being accurate, the stat used the default value, now the bar and numbers shown are what they should be.
  • Improve onSelChangedLeft to limit the accessory stripping issue ACE Arsenal loses weapon attachments of weapons in backpack. #6307 , using setUnitLoadout with a modified array would potentially break multiple other features or cause other issues, this is the best fix until we get the ability to add accessories to weapons in containers.
  • Added some fade in for the left, right, and loadout content panels to make the UI feel snappier.
  • Clear the right searchbar whenever you click on another item in the left panel (or the same one you have).

@jonpas jonpas added kind/enhancement Release Notes: **IMPROVED:** kind/bug-fix Release Notes: **FIXED:** labels May 16, 2018
@jonpas jonpas added this to the 3.13.0 milestone May 16, 2018
_currentPage deleteAt _forEachIndex;
};
} foreach _currentPage;
if (_currentIDIndex > -1) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://community.bistudio.com/wiki/deleteAt

Will not issue error when -1 index is passed making it ideal for using with find(see Example 2) or findIf(see Example 3) command

Copy link
Contributor

@dedmen dedmen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can approve!

@PabstMirror PabstMirror changed the title Various ACE Arsenal additions and fixes Arsenal - Various additions and fixes May 31, 2018
@PabstMirror PabstMirror merged commit 9618c2d into acemod:master May 31, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
@alganthe alganthe deleted the ACEArsenalNewEHs branch October 1, 2018 16:43
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
Arsenal - Various additions and fixes
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:** kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants