optimize suicide bomber zeus module

[commy2]

When merged this pull request will:

• increase check delay from 0/each frame to 1 seconds (reset to 0 in debug mode for line drawing)
• use more appropriate skillFinal
• changed spotting distance formula to increase distance linearly starting from 0 skill instead of .5 skill
• remove some very redundant parenthesis
• re-formated if control structure for readability

[commy2]

Btw. this module uses PosZ0 distance OBJECT, so it will not work correctly inside buildings or when swimming in > 1 m deep water.

[commy2]

On second thought, I don't think the math turns out to be the same. But the original one is kind of weird, I'm not sure what was intended.

Original:

skill	range
0	100
0.25	100
0.5	100
0.75	150
1	200

This PR:

skill	range
0	100
0.25	125
0.5	150
0.75	175
1	200

[jonpas]

@mharis001

[kymckay]

I think the maths makes more sense after this

[commy2]

Also I'm pretty sure one wants to use skillFinal, not just skill.
skill is something to be used only in conjunction with setSkill for manipulated scripted skill, while a script that only evaluates the skill should use skillFinal, which includes the skill coefficients of the Difficulty settings.

[commy2]

One could also argue that the area the suicide bomber scans around him should grow linearly with skill, instead of the distance, but that's probably pedantic at that point.

[mharis001]

The distance scaling in this PR is what was intended and skillFinal should be used. The PFH frequency could be changed to a macro based on if DEBUG_MODE_FULL so that the draw commands work during debug. The position format is a good point, unsure if there is one format that solves the problems or if other checks need to be performed.

[commy2]

Done.

[mharis001]

Oh no! Sorry for the confusion, I meant the changes introduced in this PR (100 + 100 * (_unit skill "spotDistance"); where 0.25 skill = 125 range is what was intended, not the original PR that added this module.