Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zeus - Add ability to unload cargo #6226

Merged
merged 3 commits into from
Jun 1, 2018

Conversation

mharis001
Copy link
Member

@mharis001 mharis001 commented Apr 5, 2018

When merged this pull request will:

  • Add ability to unload cargo from a vehicles zeus attribute display
    cargo_unload

// Validate vehicle
private _vehicle = GETMVAR(BIS_fnc_initCuratorAttributes_target,objNull);
if (isNull _vehicle || {!alive _vehicle}) exitWith {
LOG("Vehicle deleted or killed, cannot unload");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a been a while, but is log a valid macro? I ask because it's an sqf command 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes it is.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SilentSpike Don't remember
#define true false fun? ^^
The preprocessor doesn't know what SQF is. It just does it's job and hands the result off to others.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😆 Yeah I remembered, that's why I wasn't sure if we'd actually hijacked that command

Copy link
Contributor

@dedmen dedmen Apr 8, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh.. uh.. yeah we did :D
Preproc macros are case sensitive though.
And that's the devs fault if he feels like writing SQF commands in caps

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Apr 8, 2018
@jonpas jonpas added this to the 3.13.0 milestone Apr 8, 2018
@PabstMirror PabstMirror merged commit d4767eb into acemod:master Jun 1, 2018
@mharis001 mharis001 deleted the zeus-cargo-unload branch June 10, 2018 15:51
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.3 Jul 5, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Add ability to unload cargo

* Handle array index being out of bounds
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants