Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add various misc improvements for ACE Arsenal #6111

Merged
merged 13 commits into from
Feb 9, 2018

Conversation

alganthe
Copy link
Contributor

@alganthe alganthe commented Feb 1, 2018

When merged this pull request will:

  • Disable animations when the center isn't the player
  • Change the edit loadout button in 3DEN to be a menu with 2 sub-entries, one being BI VA the other ACE Arsenal
  • Revert changes to "add full arsenal" and "remove arsenal" zeus modules, create dedicated ones for ACE Arsenal
  • Add 3 new arsenal EHs
  • Add a setting to disable the identity tabs.
  • Resize the right panel to not have empty space when the "load" bar isn't present
  • Added a tooltip for the clear container button
  • Added classname copying of the current selection for the left and right panel
New EHs click to expand
Name Arguments
ace_arsenal_onLoadoutLoad loadout data (ARRAY)
ace_arsenal_loadoutImported Arsenal display (DISPLAY), (import list (BOOL)
ace_arsenal_loadoutExported Arsenal display (DISPLAY), export list (BOOL)

_ctrl ctrlEnable GVAR(enableIdentityTabs);
_ctrl ctrlSetFade ([0.6, 0] select GVAR(enableIdentityTabs));
_ctrl ctrlcommit 0;
} foreach [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ctrlcommit, foreach -> ctrlCommit, forEach

@bux
Copy link
Member

bux commented Feb 1, 2018

ace_arsenal_onLoadoutLoad totally needs the name of the loadout passed too

@alganthe
Copy link
Contributor Author

alganthe commented Feb 1, 2018

^ Done.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Feb 1, 2018
@PabstMirror PabstMirror added this to the 3.13.0 milestone Feb 1, 2018
@alganthe
Copy link
Contributor Author

alganthe commented Feb 8, 2018

Should be good to go.

@PabstMirror PabstMirror merged commit 8b9480d into acemod:master Feb 9, 2018
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.2 Apr 2, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Disable anim previews when center isn't the player

* Abuse configs to change the edit loadout 3DEN entry

* Remove inheriting as it's not needed

* Remove uneeded condition

* Add zeus modules for ACE Arsenal, revert old arsenal modules

* Add 3 new arsenal EHs

* Add a setting to disable the identity tabs in ace arsenal

* Pass loadoutName in the onloadoutLoad EH

* Change foreach to forEach and ctrlcommit to ctrlCommit

* Resize the right window when the load bar isn't there

* Add a tooltip for the "clear container" button

* Improve onKeyDown, add classname copying using ctrl+c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants