Pylons - Fix old weapons not being removed #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix #6088 - Use removeWeaponTurret instead of removeWeaponGlobal - Fix "Too Far" warning showing on completion
Dystopian
reviewed
Jan 30, 2018
addons/pylons/XEH_postInit.sqf
Outdated
| { | ||
| if (_aircraft turretLocal _x) then { | ||
| TRACE_3("removing",_aircraft,_x,_removeWeapon); | ||
| _aircraft removeWeaponTurret [_removeWeapon, [-1]]; |
There was a problem hiding this comment.
[-1] -> _x ? I didn't test yet but it looks strange.
654wak654
requested changes
Jan 31, 2018
| @@ -149,7 +149,10 @@ if (!GVAR(isCurator)) then { | |||
| isNull (GVAR(currentAircraft) getVariable [QGVAR(currentUser), objNull]) || | |||
| {(ace_player distanceSqr GVAR(currentAircraft)) > GVAR(searchDistanceSqr)} | |||
| }, { | |||
| [localize LSTRING(TooFar), false, 5] call EFUNC(common,displayText); | |||
| TRACE_3("disconnect/far",GVAR(currentAircraft), ace_player distance GVAR(currentAircraft),GVAR(currentAircraft) getVariable QGVAR(currentUser)); | |||
There was a problem hiding this comment.
There is a rogue space in the macro.
|
|
||
| // Remove the weapon of current pylon from aircraft IF weapon is only on this pylon | ||
| private _removeWeapon = ""; |
There was a problem hiding this comment.
Maybe call it _weaponToRemove?
Co-Authored-By: Ozan Eğitmen <[email protected]>
654wak654
approved these changes
Jan 31, 2018
Closed
jonpas
approved these changes
Feb 9, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Pylons - Fix old weapons not being removed Fix #6088 - Use removeWeaponTurret instead of removeWeaponGlobal - Fix "Too Far" warning showing on completion * Fix _x * Fix var name Co-Authored-By: Ozan Eğitmen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6088
Tag @654wak654
I have no idea why
removeWeaponGlobaldoesn't work for pilot seat of some RHS helis, butremoveWeaponTurretworks just fine.