Map - Add Camping Light support #6087
Conversation
Would be nice to see it blinking, but yes, it's not a big deal. |
| { | ||
| private _position = _lightSource modelToWorld (_lightSource selectionPosition getText (_x >> "name")); | ||
| private _distance = _unitPos distance _position; | ||
| _lightLevel = _lightLevel max (linearConversion [0, 10, _distance, 1, 0, true]); |
There was a problem hiding this comment.
I think we should account for light brightness as there are several objects with collision lights that wouldn't be useful
maybe something like:
_lightLevel = _lightLevel max (linearConversion [0, 10, _distance, 1, 0, true] * linearConversion [25, 2000, getNumber (_x >> "intensity"), 0, 1, true]);
There was a problem hiding this comment.
e.g. ghosthawk collision lights
There was a problem hiding this comment.
I didn't add intensity check because of this comment in Reflectors code above: @todo intensity affects range?. But it looks like you are right and intensity of MarkerLights is more important than for Reflectors. I'll add it.
There was a problem hiding this comment.
I slightly modified linearConversion range to suit all found light sources.
* Add Camping Light support * Add intensity check
When merged this pull request will:
Camping Light and some other vehicles have
MarkerLightsconfig instead ofReflectorswith hitpoints. Their lights should be considered when determining map light.Unfortunately I don't know how to consider
blinkingparameter. So blinking lights will light a map like continuous light. Not a big deal I think.