Match case for magazines in fillRightPanel (ACE Arsenal) #6044
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently you can have different case between the entry in the weapon magazines array and its actual configname...
|
What about my proposed fix of actually using the proper case instead of toLowering all magazines each time the right panel is refreshed? Replace https://github.com/alganthe/ACE3ganthe/blob/23bb184744909afdcec7cf5b2efe09a28a4a8453/addons/arsenal/functions/fnc_fillRightPanel.sqf#L89 |
CloseOnMissionEnd is bugged in 3DEN and force close the display after it's opened
|
Replace my lazy ass fix with ded's (works as intended, tested with IFA3 mags that had that issue), I also removed closeOnMissionEnd after noticing some weird behaviors in 3DEN. |
jonpas
approved these changes
Jan 15, 2018
BaerMitUmlaut
pushed a commit
that referenced
this pull request
Aug 5, 2019
* Match case for magazines in fillRightPanel Apparently you can have different case between the entry in the weapon magazines array and its actual configname... * Add possible fix for the mission end bug * Add ded's proposed fix, remove closeOnMissionEnd CloseOnMissionEnd is bugged in 3DEN and force close the display after it's opened
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
For some reason you're able to have different case between the entry in the weapon magazines array and its actual configName, meaning that some mags won't show up in the currentMag and currentMag2 tabs even tho they should.