Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Interaction - Add Flip and Push actions to Quad Bike, Kart and Static Weapons #6019

Merged
merged 7 commits into from
Feb 26, 2018
Merged

Interaction - Add Flip and Push actions to Quad Bike, Kart and Static Weapons #6019

merged 7 commits into from
Feb 26, 2018

Conversation

Dystopian
Copy link
Contributor

@Dystopian Dystopian commented Jan 3, 2018 •
edited
Loading

When merged this pull request will:

  • title;
  • add Flip action to static weapons;
  • fix Push action Russian translation.

Inspired by ACE2 Flip ATV action.

There is str_a3_cfgvehicles_quadbike_01_base_f_useractions_pressxtoflipthequad0 string (Flip the quad bike) in vanilla already, but it's not implemented and it's not universal (my one can be used for any vehicle) and it has very bad Russian translation.

Also in ACE2 there was abs (speed _target) < 3 in condition, but I can't see any sense to use it with ACE3 interaction menu.

@commy2
Copy link
Contributor

commy2 commented Jan 4, 2018

Add this also to the Karts?

@Dystopian
Copy link
Contributor Author

Karts already have Set-up the Kart vanilla useraction, but it's not so good. Besides Push action would be useful for karts. So yes, will add this.

What do you think about Flip for static weapons? I think this would be useful too.

@Drofseh
Copy link
Contributor

Drofseh commented Jan 4, 2018 •
edited
Loading

What do you think about Flip for static weapons? I think this would be useful too.

I'd love to see a Flip for statics.

@bux
Copy link
Member

bux commented Jan 4, 2018

Can I have one for tables?
(╯°□°）╯︵ ┻━┻

@shukari
Copy link
Contributor

shukari commented Jan 4, 2018

You can "Flip" static weapons allready by drag/carry them and place them again.

@Dystopian
Copy link
Contributor Author

Dystopian commented Jan 4, 2018 •
edited
Loading

@bux looks like we want small framework with canBeFlipped and canBePushed config and var values and PostInit menu adding :) Do we?

@shukari dragging can be disabled and iirc it doesn't align object to terrain.

@kymckay
Copy link
Member

kymckay commented Jan 4, 2018

My only fear with this is that a vehicle might get arma'd and clip something and explode 😆 Looks good though!

@commy2
Copy link
Contributor

commy2 commented Jan 4, 2018

As long as he does setVectorUp surfaceNormal, it at least can't collide with the terrain.
Collisions with anything else are just as bad as dragging etc.

@Dystopian Dystopian changed the title Interaction - Add Flip and Push actions to Quad Bike Interaction - Add Flip and Push actions to Quad Bike and Kart Jan 5, 2018
jonpas
jonpas reviewed Jan 5, 2018
View reviewed changes
addons/interaction/script_component.hpp Outdated
@@ -17,3 +17,6 @@
#include "\z\ace\addons\main\script_macros.hpp"

#define MACRO_DOOR_REACH_DISTANCE (AGLToASL positionCameraToWorld [0,0,0] vectorDistance AGLToASL (ACE_player modelToWorld (ACE_player selectionPosition "Head"))) + 2

// here is most suitable mass for all vanilla, CUP and RHS statics ATM (ZU-23 suits, D-30 and M119 don't suit)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ditch "here is", it's obviously here if the comment is here. ^^

@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Jan 22, 2018
@jonpas jonpas added this to the 3.13.0 milestone Jan 22, 2018
jonpas
jonpas requested changes Jan 22, 2018
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, fully dynamic framework would be nice, but it's not exactly required or needed at this time. If you so wish though, we won't have anything against it. Just so @bux can flip all the tables!

addons/interaction/CfgVehicles.hpp Outdated
class ACE_MainActions: ACE_MainActions {
class GVAR(flip) {
displayName = CSTRING(Flip);
condition = QUOTE(1 < (vectorUp _target) vectorDistance (surfaceNormal getPosATL _target) && {0 == {alive _x} count crew _target});
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First condition should be made into a common function, as it repeats.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't want to move such a small piece of code to function.

@Dystopian
Copy link
Contributor Author

@jonpas No, thank you :) I think bux just joked.

@jonpas jonpas requested a review from PabstMirror February 18, 2018 01:40
@PabstMirror PabstMirror changed the title Interaction - Add Flip and Push actions to Quad Bike and Kart Interaction - Add Flip and Push actions to Quad Bike, Kart and Static Weapons Feb 26, 2018
@PabstMirror PabstMirror merged commit 3feafc4 into acemod:master Feb 26, 2018
@Dystopian Dystopian deleted the flip_quadbike branch February 26, 2018 18:34
@PabstMirror PabstMirror removed this from the 3.13.0 milestone Apr 2, 2018
@PabstMirror PabstMirror added this to the 3.12.2 milestone Apr 2, 2018
@Snak3Doc
Copy link

Possibly add push actions to boat class? a fix for the beached RHIB

@Dystopian
Copy link
Contributor Author

@Snak3Doc already in my todo list

BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@Dystopian @PabstMirror
Interaction - Add Flip and Push actions to Quad Bike, Kart and Static…
c7b8fb8 
… Weapons (#6019)

* Add Flip and Push actions to Quad Bike

* Add actions to karts and static weapons

* Move magic number to macro

* Ditch here is

* Move condition to function
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PabstMirror PabstMirror PabstMirror approved these changes

@jonpas jonpas jonpas approved these changes

Assignees
No one assigned
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.12.2
Development

Successfully merging this pull request may close these issues.
9 participants
@Dystopian @commy2 @Drofseh @bux @shukari @kymckay @Snak3Doc @jonpas @PabstMirror