Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make setHidden use forgetTarget #5987

Merged
merged 2 commits into from
Jan 2, 2018
Merged

make setHidden use forgetTarget #5987

merged 2 commits into from
Jan 2, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Dec 29, 2017

When merged this pull request will:

  • title
    Question is if this breaks anything else? Maybe just apply it to enemy groups?

@commy2 commy2 added the kind/bug-fix Release Notes: **FIXED:** label Dec 29, 2017
@commy2 commy2 added this to the 3.13.0 milestone Dec 29, 2017
@PabstMirror
Copy link
Contributor

PabstMirror commented Dec 29, 2017 •
edited
Loading

What is locality on forgetTarget?

{
    if (local _x) then { _x forgetTarget _object; };
} forEach allGroups;

in case the command is global and causes network traffic?

@commy2
Copy link
Contributor Author

commy2 commented Dec 29, 2017 •
edited
Loading

I just assumed it's AG EL, since it's the anti-reveal. This statusEffect is a global one.

@kymckay
Copy link
Member

kymckay commented Dec 29, 2017 •
edited
Loading

I have a feeling it may be global since it was added in A3. I wish we had a quick way to check without relying on biki or booting up two instances of arma 😛

@PabstMirror
Copy link
Contributor

Should we revel to previous knowsAbout when they wake up?

@commy2
Copy link
Contributor Author

commy2 commented Dec 29, 2017

They'd be revealed over time. I think it's better not to.

@commy2 commy2 self-assigned this Jan 2, 2018
@commy2 commy2 modified the milestones: 3.13.0, 3.12.1 Jan 2, 2018
@commy2 commy2 merged commit ef77bb0 into master Jan 2, 2018
@commy2 commy2 deleted the setHidden-forgetTarget branch January 2, 2018 15:28
Dystopian
Dystopian reviewed Jan 2, 2018
View reviewed changes
addons/common/XEH_postInit.sqf Outdated
@@ -54,7 +54,9 @@
_object setVariable [QGVAR(oldVisibility), _vis];
_object setUnitTrait ["camouflageCoef", 0];
{
_x forgetTarget _object;
if (side _x != side group _object) then {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this will not work if side _object == ENEMY

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We actually just discussed this internally, it's quite edge case. One fix would just be to do:

if (side _x != side _object)

Copy link
Member

@kymckay kymckay Jan 2, 2018 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other would be to just have all groups except their own forget them (for healing).

@BaerMitUmlaut BaerMitUmlaut mentioned this pull request Jan 10, 2018
Closed
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@commy2
Merge pull request #5987 from acemod/setHidden-forgetTarget
546641f 
make setHidden use forgetTarget
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kymckay kymckay kymckay left review comments

@Dystopian Dystopian Dystopian left review comments

@bux bux bux approved these changes

Assignees

@commy2 commy2

Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Milestone
3.12.1
Development

Successfully merging this pull request may close these issues.
5 participants
@commy2 @PabstMirror @kymckay @bux @Dystopian