Add a function to port BI VA loadouts to ACE Arsenal #5943
Conversation
| @@ -0,0 +1,40 @@ | |||
| /* | |||
| * Author: alganthe | |||
| * Port VA loadouts to ACE Arsenal | |||
| * Port VA loadouts to ACE Arsenal | ||
| * | ||
| * Arguments: | ||
| * 0: Write over similarly named loadouts in ACE Arsenal <BOOL> |
|
Maybe add a button somewhere? |
|
it need to load the loadout before saving it, that could be easily abused. |
|
Force it to only work in SP |
|
now that I think about it I could add a button in 3DEN instead of changing the ACE Arsenal interface. |
|
If I add such a button, should I place it under tools or make an ACE category for the main bar? |
|
I removed the override argument (it always does it now) and added a button under tools in 3DEN: |
|
added an error message for both:
should be good to go. |
addons/arsenal/stringtable.xml
Outdated
| @@ -433,5 +433,17 @@ | |||
| <Italian>Impossibile aprire l'arsenale ACE</Italian> | |||
| <Japanese>ACE 武器庫を開けません</Japanese> | |||
| </Key> | |||
| <Key ID= "STR_ACE_Arsenal_portLoadoutsText"> | |||
| <English>import BI VA loadouts to ACE Arsenal</English> | |||
There was a problem hiding this comment.
Import (capitalization).
I think something like Import Vanilla Arsenal loadouts to ACE Arsenal would be more understandable, but longer.
There was a problem hiding this comment.
The issue is that it translates poorly into other languages, on the other hand "BI VA" is pretty much universal.
addons/arsenal/stringtable.xml
Outdated
| <French>Importe les loadouts de BI VA dans ACE Arsenal</French> | ||
| </Key> | ||
| <Key ID= "STR_ACE_Arsenal_portLoadoutsPlayerError"> | ||
| <English>No player unit available!</English> |
There was a problem hiding this comment.
I would add instruction on what to do to make it work, such as No player unit available! Place a unit and mark it as "Player" or something.
There was a problem hiding this comment.
huh, surprisingly you can fit a lot more characters than I thought in those messages
addons/arsenal/stringtable.xml
Outdated
| <French>Aucune unité joueur disponible !</French> | ||
| </Key> | ||
| <Key ID= "STR_ACE_Arsenal_portLoadoutsLoadoutError"> | ||
| <English>No loadouts to import</English> |
addons/arsenal/stringtable.xml
Outdated
| <English>No player unit available!</English> | ||
| <French>Aucune unité joueur disponible !</French> | ||
| <English>No player unit available! Place a unit and mark it as "Player".</English> | ||
| <French>Aucune unité joueur disponible ! Placez une unité et marquez la en tant que "joueur"</French> |
* Add a function to port BI VA loadouts to ACE Arsenal * Fix typos in the header * Remove override argument, add button in 3DEN * Add null player exception * Remove unused passed argument * Add error messages to portVALoadouts * Change error messages * Add missing dot in string
When merged this pull request will: