Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated functionality for 3.12.0 #5878

Merged
merged 3 commits into from
Dec 10, 2017
Merged

Remove deprecated functionality for 3.12.0 #5878

merged 3 commits into from
Dec 10, 2017

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented Dec 9, 2017

When merged this pull request will:

  • Title

@kymckay kymckay added the kind/cleanup Release Notes: **CHANGED:** label Dec 9, 2017
@kymckay kymckay added this to the 3.12.0 milestone Dec 9, 2017
@ulteq
Copy link
Contributor

ulteq commented Dec 9, 2017

When merged this pull request will:

This removes deprecated functionality from:

  • Cargo
  • Rearm
  • Spectator

@PabstMirror
Copy link
Contributor

I would feel a lot better leaving the module as

    class GVAR(makeLoadable): ACE_Module {
        displayName "Delete (No Functionality)";
    };

as a bad vehicle can break loading the mission / opening in editor.

@kymckay
Copy link
Member Author

kymckay commented Dec 10, 2017

Yeah I think that's a good idea, was thinking of it myself but unsure 👍

This is just to prevent existing missions from breaking due to a missing
object.
@kymckay kymckay merged commit 845f365 into master Dec 10, 2017
@kymckay kymckay deleted the rm-deprecated branch December 10, 2017 13:38
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Remove deprecated functionality for 3.12.0
* Remove associated deprecated module icon
* Restore a dummy version of old module

This is just to prevent existing missions from breaking due to a missing
object.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/cleanup Release Notes: **CHANGED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants