Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing HE magazine for Blackfish Autocannon. #5854

Merged
merged 3 commits into from
Dec 6, 2017

Conversation

xrufix
Copy link
Contributor

@xrufix xrufix commented Dec 4, 2017

When merged this pull request will:

  • Adds magazine from HE muzzle to AP muzzle for Blackfish Autocannon (autocannon_40mm_VTOL_01)
  • Removes muzzle tweak from all autocannons in ace_vehicles to fix problems with inheriting from autocannon classes.
  • Fixes Black Fish bushmaster issue #5847
  • Changes displayName to "L/60 Bofors Autocannon". See reason below.

@xrufix
Copy link
Contributor Author

xrufix commented Dec 4, 2017

I would also change the displayName to "L/60 Bofors Autocannon" in realisticnames. This is the cannon currently used on the AC-130 and resembles the ingame model. Compare attached screenshot with real life counterpart (source: https://upload.wikimedia.org/wikipedia/commons/b/bc/Bofors_guns_on_Spectre_gunship.jpg).

grafik

Bofors L/60 on AC-130

@kymckay kymckay added kind/bug-fix Release Notes: **FIXED:** impact/trivial labels Dec 5, 2017
@kymckay kymckay added this to the 3.12.0 milestone Dec 5, 2017
@PabstMirror
Copy link
Contributor

PabstMirror commented Dec 5, 2017

class autocannon_40mm_CTWS: autocannon_Base_F {
    class AP: autocannon_Base_F {
        magazines[] = {"40Rnd_40mm_APFSDS_shells","40Rnd_40mm_APFSDS_Tracer_Red_shells","40Rnd_40mm_APFSDS_Tracer_Green_shells","40Rnd_40mm_APFSDS_Tracer_Yellow_shells","60Rnd_40mm_GPR_shells","60Rnd_40mm_GPR_Tracer_Red_shells","60Rnd_40mm_GPR_Tracer_Green_shells","60Rnd_40mm_GPR_Tracer_Yellow_shells"};
        magazineReloadTime = 0;
    };
    muzzles[] = {"AP"};

For the apc cannon we move all the magazines to the AP muzzle and then disable the HE muzzle.
I'm not really sure why, moves ammo type switch to action menu instead of F key?

For the VTOL: we could also just restore the original muzzle config muzzles[] = {"AP", "HE"};

@xrufix
Copy link
Contributor Author

xrufix commented Dec 6, 2017

I don't know why that's done either, but decided to mimic it because of consistency. Otherwise i would have prefered muzzles[] = {"AP", "HE"};.

@commy2
Copy link
Contributor

commy2 commented Dec 6, 2017

I'd say we just remove that muzzle tweak. Was something Flummi did for APC's years ago (AGM), but since then many new assets have been added without anyone updating this.
I think it just causes problems at this point.

@xrufix
Copy link
Contributor Author

xrufix commented Dec 6, 2017

Then i'll remove it.

@PabstMirror PabstMirror merged commit 0630ebd into acemod:master Dec 6, 2017
@xrufix xrufix deleted the blackfish branch January 1, 2018 16:33
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* Fix missing HE magazine for Blackfish Autocannon.

* Change displayname of Blackfish autocannon to "L/60 Bofors"

* Remove muzzle tweak from autocannons.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
impact/trivial kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Black Fish bushmaster issue
4 participants