Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add sway factor option to advanced fatigue #5773

Merged
merged 4 commits into from
May 19, 2018
Merged

Add sway factor option to advanced fatigue #5773

merged 4 commits into from
May 19, 2018

Conversation

jlillis
Copy link
Contributor

@jlillis jlillis commented Nov 15, 2017

When merged this pull request will:

  • Add a sway factor option to advanced fatigue that allows the amount of weapon sway to be customized.

@jonpas jonpas added this to the 3.13.0 milestone Nov 15, 2017
@jonpas jonpas added the kind/feature Release Notes: **ADDED:** label Nov 15, 2017
@ulteq ulteq assigned BaerMitUmlaut and unassigned ulteq Nov 16, 2017
@ulteq ulteq modified the milestones: 3.13.0, 3.12.0 Nov 16, 2017
@ulteq ulteq added kind/feature kind/feature Release Notes: **ADDED:** and removed kind/feature Release Notes: **ADDED:** kind/feature labels Nov 19, 2017
@PabstMirror PabstMirror mentioned this pull request Nov 30, 2017
Merged
@bux bux modified the milestones: 3.12.0, 3.13.0 Dec 10, 2017
@bux
Copy link
Member

bux commented Dec 10, 2017

@jlillis @xrufix could you work together on merging your PR's? I'd really like to see them become a thing 👍

@bux bux modified the milestones: 3.13.0, Ongoing Dec 10, 2017
xrufix added a commit to xrufix/ACE3 that referenced this pull request Dec 10, 2017
@xrufix
Prepare for merging with acemod#5773.
7c4adee
@xrufix
Copy link
Contributor

xrufix commented Dec 10, 2017

@bux I updated my PR with jlillis' calculations (7c4adee). Merge this PR first, then mine. Should be fine then.

@jonpas jonpas requested a review from BaerMitUmlaut February 18, 2018 01:41
@jonpas
Copy link
Member

jonpas commented Feb 18, 2018

@BaerMitUmlaut Take a look please.

jonpas
jonpas requested changes Feb 18, 2018
View reviewed changes
Copy link
Member

@jonpas jonpas left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACE Settings entry and module addition should be removed.

@commy2 commy2 merged commit 104efe2 into acemod:master May 19, 2018
@PabstMirror PabstMirror removed this from the Ongoing milestone Aug 9, 2018
@PabstMirror PabstMirror added this to the 3.12.3 milestone Aug 9, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@xrufix
Prepare for merging with #5773.
d3efd8f
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
@commy2
Merge pull request #5773 from jlillis/adv_fatigue_sway_factor
afea79b 
Add sway factor option to advanced fatigue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ulteq ulteq ulteq approved these changes

@jonpas jonpas jonpas approved these changes

@BaerMitUmlaut BaerMitUmlaut Awaiting requested review from BaerMitUmlaut

Assignees

@BaerMitUmlaut BaerMitUmlaut

Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Milestone
3.12.3
Development

Successfully merging this pull request may close these issues.
8 participants
@jlillis @bux @xrufix @jonpas @ulteq @commy2 @PabstMirror @BaerMitUmlaut