Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

weaponSelect CBA Setting #5581

Merged
merged 4 commits into from
Feb 9, 2018
Merged

weaponSelect CBA Setting #5581

merged 4 commits into from
Feb 9, 2018

Conversation

commy2
Copy link
Contributor

@commy2 commy2 commented Oct 3, 2017

This is an easy one.

@commy2 commy2 added the kind/feature Release Notes: **ADDED:** label Oct 3, 2017
@PabstMirror PabstMirror added this to the CBA Settings milestone Oct 3, 2017
@PabstMirror
Copy link
Contributor

PabstMirror commented Oct 4, 2017

Not really related to this PR, just something I saw in testing
(was wondering why we only localized 1 of the 3 strings)

[
    "test1", "CHECKBOX",
    ["test1", LSTRING(SettingDisplayTextDesc)],
     localize "STR_ACE_common_ACEKeybindCategoryWeapons"
] call CBA_settings_fnc_init;

[
    "test2", "CHECKBOX",
    ["test2"],
    "STR_ACE_common_ACEKeybindCategoryWeapons"
] call CBA_settings_fnc_init;

Running both of these produces weird results.
It opens on the localized category with only test1
Category lists both "ACE3 Weapons" and "STR_ACE_common_ACEKeybindCategoryWeapons"
The "STR" has nothing in it, reselecting the localized one then shows both options.

I'm thinking we should just have CBA localize categories on init so there's no problems on category filtering?
edit: fixed by CBATeam/CBA_A3#814

@commy2
Copy link
Contributor Author

commy2 commented Dec 29, 2017

lgtm, can't approve what I opened.


[QGVAR(displayText), "CHECKBOX",
[LSTRING(SettingDisplayTextName), LSTRING(SettingDisplayTextDesc)],
"ACE Uncategorized",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there some sort of inventory category this would be more suited to?

@commy2
Copy link
Contributor Author

commy2 commented Dec 29, 2017

UI

@PabstMirror
Copy link
Contributor

Requires #5752

@PabstMirror PabstMirror merged commit eedb9fe into master Feb 9, 2018
@PabstMirror PabstMirror deleted the weaponSelectSetting branch February 9, 2018 20:28
@PabstMirror PabstMirror modified the milestones: 3.13.0, 3.12.2 Apr 2, 2018
BaerMitUmlaut pushed a commit that referenced this pull request Aug 5, 2019
* weaponSelectCBASetting

* Update to movedToSQF

* Add category
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Release Notes: **ADDED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants