Fix the issue that SFX variants are not global #5335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent players can get different pressure Cookoff sounds to prevent that i split up the sounds in 3 types and used a Weighted select to have the befor used values back
kymckay
reviewed
Jul 6, 2017
addons/cookoff/CfgSFX.hpp
Outdated
| sound[] = {QPATHTOF(sounds\cookoff_mid_pressure.ogg),6,1,400,1,0,0,0}; | ||
| sounds[] = {"sound"}; | ||
| titles[] = {}; | ||
| empty[] = {"",0,0,0,0,0,0,0}; |
There was a problem hiding this comment.
Probably make sense to have these classes inherit and just change the name and sound[] properties
There was a problem hiding this comment.
I thought I'd done that. wired.
kymckay
approved these changes
Jul 8, 2017
jonpas
pushed a commit
that referenced
this pull request
Jul 10, 2017
* Fix the issue that SFX variants are not global what means that different players can get different pressure Cookoff sounds to prevent that i split up the sounds in 3 types and used a Weighted select to have the befor used values back * add todo for 1.74 * inherit in CfgSFX from 1 class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what means that different players can get different pressure Cookoff sounds
to prevent that I split up the sounds in 3 types and used a Weighted select to have the before used values back