Refuel - change nozzle position calc #5279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neviothr
reviewed
Jun 14, 2017
| @@ -21,7 +21,7 @@ params [["_unit", objNull, [objNull]], ["_target", objNull, [objNull]]]; | |||
| private _fuel = [_target] call FUNC(getFuel); | |||
|
|
|||
| [ | |||
| REFUEL_PROGRESS_DURATION * 2.5, | |||
| TIME_PROGRESSBAR(REFUEL_PROGRESS_DURATION * 2), | |||
There was a problem hiding this comment.
Shouldn't REFUEL_PROGRESS_DURATION be a GVAR()?
There was a problem hiding this comment.
No, this is not flow rate, it's how long it takes to check current fuel level of a vehicle. Macro is 2s, so this makes it 4s.
jonpas
reviewed
Jun 22, 2017
| #define TIME_PROGRESSBAR(X) ((X) * 0.075) | ||
| #else | ||
| #define TIME_PROGRESSBAR(X) (X) | ||
| #endif |
There was a problem hiding this comment.
We could do that globally, and just set it to 0 or 0.5 (so it's visible that it happens at least) when defined?
There was a problem hiding this comment.
TIME_PROGRESSBAR is already in rearm
Rearm, Refuel are the main ones with some long progress bars that make testing tedious.
Might actually cause problems on some things like repacking and medical surgery, not sure.
There was a problem hiding this comment.
I see. Would be done separate of this PR anyways.
jonpas
approved these changes
Jun 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #5143
Removes the old binary search and now uses
lineIntersectsSurfacesDefault is to aim at player's viewing angle (what you see is what you get) instead of using model center