Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix isFeatureCameraActive for Spectator enhacements #5269

Merged
merged 2 commits into from
Jun 13, 2017
Merged

Fix isFeatureCameraActive for Spectator enhacements #5269

merged 2 commits into from
Jun 13, 2017

Conversation

Fusselwurm
Copy link
Contributor

At the moment, isFeatureCameraActive does not detect ACE spectator mode, because ace_spectator_camera as a variable was removed in 77c2b99 .
spectator module initializes three separate cameras instead, of which for example ace_spectator_freeCamera could be used to check if spec mode is active.

ace_spectator_camera was removed in 77c2b99 .
spectator module initializes three separate cameras instead, of which for example ace_spectator_freeCamera can be used to check if spec mode is active
@kymckay
Copy link
Member

kymckay commented Jun 11, 2017

This could be changed to check EGVAR(spectator,isSet) as it will also support the overhaul once it is merged for 3.11, but otherwise 👍

@jonpas jonpas added the kind/bug-fix Release Notes: **FIXED:** label Jun 11, 2017
@jonpas jonpas added this to the 3.10.0 milestone Jun 11, 2017
@jonpas
Copy link
Member

jonpas commented Jun 11, 2017

Let's do what @SilentSpike said, and we can merge. missionNamespace getVariable [nil, objNull] will return objNull btw? If not, we need to make sure that function still works if spectator is not present (as in removed PBO).

@kymckay
Copy link
Member

kymckay commented Jun 11, 2017

@jonpas Isn't that the whole point of the second getVariable argument? 😆

Also note that isSet is a boolean, just to clarify. Will be true when spectator is open.

@jonpas
Copy link
Member

jonpas commented Jun 11, 2017

Uh, I could bet I wanted to write something else there after writing the rest... but I forgot now.

@jonpas jonpas changed the title fix isFeatureCameraActive for spec Fix isFeatureCameraActive for Spectator enhacements Jun 12, 2017
@jonpas jonpas merged commit e770f66 into acemod:release-3.10.0 Jun 13, 2017
@jonpas jonpas added the ignore-changelog Release Notes: Excluded label Jun 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore-changelog Release Notes: Excluded kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants