-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conform function headers to coding guidelines #5255
Conversation
* | ||
* | ||
* Arguments: | ||
* Nothing |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be None
, I noticed it was wrong in some other files before as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The script will now complain about this too after latest commit 😄
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeay. Well we can put this as WIP so I can fix this in the same tempo that silentspike updates the script and we just do both at the same time :)
I was just bored and didnt feel like scripting so did this.
Done! No more errors! Plus new version of the software only public functions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I say merge this ASAP to prevent merge conflicts. If there are other things to fix in headers, they can be done separately from this.
DO IT NAOW! |
When merged this pull request will:
I believe this is a label "impact/trivial" because it's only headers