Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add realistic names to dynamic loadout classes #5185

Merged
merged 2 commits into from
May 26, 2017
Merged

Add realistic names to dynamic loadout classes #5185

merged 2 commits into from
May 26, 2017

Conversation

kymckay
Copy link
Member

@kymckay kymckay commented May 20, 2017

When merged this pull request will:

@kymckay kymckay added 1.70 kind/bug-fix Release Notes: **FIXED:** labels May 20, 2017
@kymckay kymckay added this to the 3.10.0 milestone May 20, 2017
class I_Plane_Fighter_03_dynamicLoadout_F: Plane_Fighter_03_dynamicLoadout_base_F {
displayName = CSTRING(Plane_Fighter_03_Name);
};

// uavs
class UAV_02_base_F;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering while looking through the configs here, why are we not just adding the names to the base classes where applicable? This one for example, they all inherit from it anyway.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because displayName is defined here.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not though, it's inherited from the base class 😛

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

air_f_gamma\Plane_Fighter_03\config.cpp

class I_Plane_Fighter_03_dynamicLoadout_F: Plane_Fighter_03_dynamicLoadout_base_F {
	displayName = "$STR_A3_CfgVehicles_O_Plane_Fighter_03_CAS0";

did I miss anything?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The line I commented on 😆

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For reference:

		class UAV_02_base_F: UAV //inherits 15 parameters from bin\config.bin/CfgVehicles/UAV, sources - ["A3_Drones_F_Air_F_Gamma_UAV_02"]
		{
			features = "Randomization: No						<br />Camo selections: 1 - the whole body						<br />Script door sources: None						<br />Script animations: None						<br />Executed scripts: None						<br />Firing from vehicles: No						<br />Slingload: Slingloadable						<br />Cargo proxy indexes: None";
			author = "Bohemia Interactive";
			_generalMacro = "UAV_02_base_F";
			displayName = "MQ-4A Greyhawk";
                        ...
		};

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Vanilla Config:
class UAV_02_base_F: UAV {displayName = "MQ-4A Greyhawk";}
class B_UAV_02_F: UAV_02_base_F uses inheritance
class O_UAV_02_F: UAV_02_base_F {displayName = "K40 Ababil-3";};
class I_UAV_02_F: UAV_02_base_F {displayName = "K40 Ababil-3";}
So adding it to all is necessary

@kymckay kymckay merged commit 2496628 into master May 26, 2017
@kymckay kymckay deleted the dynamicnames branch May 26, 2017 06:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants