Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Zeus teleport players module #5175

Merged
merged 4 commits into from
May 26, 2017
Merged

Fix Zeus teleport players module #5175

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
98a3e98
Add dummy function to zeus UI modules
kymckay May 18, 2017
176dbcf
Fix zeus teleport module for non-local units
kymckay May 18, 2017
f3a679b
Account for logic deletion
kymckay May 18, 2017
b7a0935
Fix incorrect position format
kymckay May 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions addons/zeus/functions/fnc_moduleTeleportPlayers.sqf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,10 +34,10 @@ if (_group) then {
{
moveOut _x;

// Must be ran where local
private _attached = attachedTo _logic;
if (isNull _attached) then {
[QGVAR(moveToRespawnPosition), [_x, getPos _logic], _x] call CBA_fnc_targetEvent;
// Function takes position AGL and must be ran where local
[QGVAR(moveToRespawnPosition), [_x, _logic modelToWorld [0,0,0]], _x] call CBA_fnc_targetEvent;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spaces after , in modelToWorld? [0,0,0] -> [0, 0, 0].

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure if we have a set standard for that, but personally I only use spaces where it helps with readability. In this case I'd argue that adding spaces actually has the opposite effect.

} else {
[QGVAR(moveToRespawnPosition), [_x, _attached], _x] call CBA_fnc_targetEvent;
};
Expand Down