Fix setVariablePublic reseting to old values #4938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bux
approved these changes
Feb 22, 2017
commy2
reviewed
Feb 23, 2017
| @@ -48,6 +48,7 @@ TRACE_2("Starting Embargo", _varName, _delay); | |||
|
|
|||
| //If value at start of embargo doesn't equal current, then broadcast and start new embargo | |||
| if (!(_value isEqualTo _curValue)) then { | |||
| [_object, _varName, _curValue] call FUNC(setVariablePublic); | |||
| _this set [2, _curValue]; | |||
| _this call FUNC(setVariablePublic); | |||
There was a problem hiding this comment.
Why was this changed? I think it's bad practice to modify the input array.
There was a problem hiding this comment.
This will pass 4th arg which may or may not exist
thojkooi
pushed a commit
that referenced
this pull request
Mar 13, 2017
* Fix setVariablePublic reseting to old values * Don't drop delay time
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #4932
setVariablePublic should call itself again with the current value, not the value from the first call