-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vehicle quick mount #4931
Vehicle quick mount #4931
Conversation
Ref ACEX PR: acemod/ACEX#29 |
_sortedSeats append _seats; | ||
|
||
{ | ||
private _unit = _target call compile format ["assigned%1 _this", _x]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
???
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's to avoid repeating code
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
assignedDriver
does not report the driver of a vehicle etc.
{ | ||
private _unit = _target call compile format ["assigned%1 _this", _x]; | ||
|
||
if (_unit isEqualType objNull && {!isNull _unit} && {!alive _unit}) exitWith { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
_unit isEqualType objNull
As opposed to what?
If it's not OBJECT, line 65 will error anyway.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What does line 65 have to do with _unit
? It's not even used after this exitWith
block.
Well made video @jameslkingsley |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can't quick mount into a AH-9 that has a pilot.
Problem seen else where in ace, it's a copilot seat that's also a turret.
addons/quickmount/CfgVehicles.hpp
Outdated
class ACE_Module; | ||
class GVAR(module): ACE_Module { | ||
author = ECSTRING(common,ACETeam); | ||
category = "ACEX"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"ACE"
{ACE_player getVariable ["ace_unconscious", false]} | ||
) exitWith {}; | ||
|
||
private _start = AGLtoASL positionCameraToWorld [0, 0, 0]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
private _start = AGLtoASL (ACE_player modelToWorldVisual (ACE_player selectionPosition "pilot"));
I think this will work a lot better for people using 3rd person
Tweaked the seat search to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested this on several vehicles and seems to be working correctly
When merged this pull request will:
The idea of this module is to provide a fail-safe for when action menus fail to appear when you're trying to quickly mount a vehicle. An example is when you're running towards an extraction helicopter and you're unable to get in when in real life you know you should be able to.
Demonstration: https://www.youtube.com/watch?v=3LWhYdG02xQ
I still need to convert it to ACE, just leaving it here for now.