-
Notifications
You must be signed in to change notification settings - Fork 739
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Function to Show BIS Style Curator Messages #4844
Conversation
The variant with format is not documented and due to the params probably also not functional. |
Oh yes, will add that. It is functional, common's displayTextStructured works the same way. |
@@ -0,0 +1,30 @@ | |||
/* | |||
* Author: 654wak654 | |||
* Shows a zeus message through the BIS function, handles localization |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing full stop.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most headers don't have dots there?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They should. :)
You then take an array within an array as a parameter, without a second parameter. I think just passing what you would pass |
…o 654wak654-zeus-messages
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, I added support for non-string args just like normal format
* Add showMessage fnc that shows BIS curator messages * Add documentation * Make function simpler * Modify to fir new syntax * Handle non-string args
When merged this pull request will:
BIS_fnc_showCuratorFeedbackMessage
for zeus messages, which shows a slightly fancier message on the top bar of the zeus ui.