Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Function to Show BIS Style Curator Messages #4844

Merged
merged 7 commits into from
Mar 2, 2017
Merged

New Function to Show BIS Style Curator Messages #4844

merged 7 commits into from
Mar 2, 2017

Conversation

654wak654
Copy link
Contributor

When merged this pull request will:

  • Add a function for zeus messages and change all displayTextStructured calls to it. New function uses BIS_fnc_showCuratorFeedbackMessage for zeus messages, which shows a slightly fancier message on the top bar of the zeus ui.

@BaerMitUmlaut
Copy link
Member

The variant with format is not documented and due to the params probably also not functional.

@654wak654
Copy link
Contributor Author

654wak654 commented Jan 20, 2017

The variant with format is not documented and due to the params probably also not functional.

Oh yes, will add that. It is functional, common's displayTextStructured works the same way.

@@ -0,0 +1,30 @@
/*
* Author: 654wak654
* Shows a zeus message through the BIS function, handles localization
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing full stop.

Copy link
Contributor Author

@654wak654 654wak654 Jan 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most headers don't have dots there?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They should. :)

@jonpas jonpas added the kind/enhancement Release Notes: **IMPROVED:** label Jan 20, 2017
@jonpas jonpas added this to the 3.9.0 milestone Jan 20, 2017
@BaerMitUmlaut
Copy link
Member

You then take an array within an array as a parameter, without a second parameter. I think just passing what you would pass format might be a little nicer.

@654wak654 654wak654 changed the title New Function to Shows BIS Style Curator Messages New Function to Show BIS Style Curator Messages Jan 23, 2017
@PabstMirror PabstMirror modified the milestones: 3.9.1, 3.9.0 Feb 10, 2017
@PabstMirror PabstMirror changed the base branch from master to release March 2, 2017 23:46
@PabstMirror PabstMirror changed the base branch from release to master March 2, 2017 23:46
Copy link
Contributor

@PabstMirror PabstMirror left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I added support for non-string args just like normal format

@PabstMirror PabstMirror merged commit 3aa55b1 into acemod:master Mar 2, 2017
@654wak654 654wak654 deleted the zeus-messages branch March 3, 2017 10:34
thojkooi pushed a commit that referenced this pull request Mar 13, 2017
* Add showMessage fnc that shows BIS curator messages

* Add documentation

* Make function simpler

* Modify to fir new syntax

* Handle non-string args
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants