Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic cycle attack profile key for missile guidance #4787

Merged
merged 5 commits into from
Feb 10, 2017

Conversation

PabstMirror
Copy link
Contributor

Replace the javelin specific key with one that will work for any missileGuidance weapon.

@PabstMirror PabstMirror added the kind/enhancement Release Notes: **IMPROVED:** label Dec 26, 2016
@PabstMirror PabstMirror added this to the 3.9.0 milestone Dec 26, 2016
bux
bux previously requested changes Jan 9, 2017
@@ -0,0 +1,67 @@
/*
* Author: PabstMirror
* Cycles fire mode for any missileGuidance enabled ammo that has multiiple attack profiles
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

typo

// #define DEBUG_MODE_FULL
#include "script_component.hpp"

TRACE_1("cycle fire mode", _this);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

space in macro?

@PabstMirror
Copy link
Contributor Author

@bux - fixed

Copy link
Member

@jonpas jonpas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Quick read, looks good.

@PabstMirror PabstMirror merged commit 78a55d4 into master Feb 10, 2017
@PabstMirror PabstMirror deleted the cycleAttackProfile branch February 10, 2017 19:01
thojkooi pushed a commit that referenced this pull request Mar 13, 2017
* Generic cycle attack profile key for missile guidance

* Add hint for weapons without huds

* Fix Korean strings

* Cleanup
thojkooi pushed a commit that referenced this pull request Mar 13, 2017
* Generic cycle attack profile key for missile guidance

* Add hint for weapons without huds

* Fix Korean strings

* Cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/enhancement Release Notes: **IMPROVED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants