Mortar interaction and ammunition handling

[VKing6]

This is a port of code originally written by Grey and Glowbal at 16AA.

Goals of this branch is to remove the multiple-round magazines for the mortars and restricting them to loading 1 round at a time and to give assistant gunners and ammo carriers something to do. The plan is to make this module-controlled.

Current status:

• Port major script components to ACE
• Add interaction menu support for loading rounds
• Add new mortar magazines and make them carriable by infantry
• Port proper inventory images and ground models for new magazines
• Implement options in module to avoid changing existing missions
  • Add module settings
  • Don't show loading/unloading actions if ammunition handling is not set
  • Init mortar to replace weapon and remove vanilla magazines if ammunition handling is set
• Zeus testing
• Unload rounds to player inventory
• Update module documentation and class list
• Ammo boxes
• Translations
• MP testing
• Make the mortar reloadable by the gunner with a time penalty Eh too complicated for now; the time penalty will be having to get out and back in between shots.

[jokoho48]

@VKing6 i will take a look to the Models tomorrow

[jokoho48]

TAAAAAB

[Grey-Soldierman]

You can blame me for awful code. Im glad you guys are finding it helpful though. If there is any stuff that it links to in the main 16AA modpack that you want/need just let me know and ill pass the source files along.

[VKing6]

Hey I can't claim to write the best code myself (why do you think I wanted to take yours in the first place :p), I'm just more pedantic.

[VKing6]

Now taking suggestions on the best way to prepare the mortars if ammunition handling is enabled.

The challenges:

• Weapon must be replaced
• Default magazines must be removed
• Consideration for missions where no mortars are placed on mission start, but where mortars will be assembled during play (mortars that are disassembled and reassembled should be okay)

[bux]

• Zeus spawned mortars (?)

[VKing6]

Should these three eventhandlers be defined in postinit rather than clientinit?

[VKing6]

This GVAR isn't read from the module in time to work on preplaced mortars.
Any suggestions on how I can delay execution until the variable's been read?

[jokoho48]

if (!EGVAR(common,settingsInitFinished)) exitWith {
    EGVAR(common,runAtSettingsInitialized) pushBack [{
        if (GVAR(useAmmoHandling)) then {
            _this call FUNC(mortarInit)
        };
    }, _this];
};
_this call FUNC(mortarInit);

[VKing6]

Okay I've written a functional init script that works on reassembled mortars as well as preplaced ones (should work on zeus or script-placed ones as well, but haven't tested yet).

I'd love to get some feedback on the above issue in initPost as well as a general critique of fnc_mortarInit

[VKing6]

Made Zeus compatible.
AI and Zeus-controlled AI can use the mortar as normal until a player enters it, which initializes the mortar for ammunition handling.

[VKing6]

I'd like to have this tested for 3.5.0, as I think it's ready (unless testing shows something horribly broken ofc).

[VKing6]

Switched over to playerVehicleChanged EH instead of GetIn/InitPost on commy's suggestion. Seems to work a lot smoother, but I'll have to do another MP dedi test.

[VKing6]

Calling this good to merge from my end.