Ballistics - Improve arsenal muzzle velocity stat #10594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rautamiekka
suggested changes
Dec 22, 2024
| private _muzzleVelocity = getNumber (_configMagazine >> "initSpeed"); | ||
|
|
||
| private _abAdjustText = ""; | ||
| private _useAB = missionNamespace getVariable [QEGVAR(advanced_ballistics,enabled), false] && {EGVAR(advanced_ballistics,barrelLengthInfluenceEnabled)}; |
There was a problem hiding this comment.
Boolean checks are too fast for lazy eval. If anything, the order should be flipped:
Suggested change
| private _useAB = missionNamespace getVariable [QEGVAR(advanced_ballistics,enabled), false] && {EGVAR(advanced_ballistics,barrelLengthInfluenceEnabled)}; | |
| private _useAB = EGVAR(advanced_ballistics,barrelLengthInfluenceEnabled) && {missionNamespace getVariable [QEGVAR(advanced_ballistics,enabled), false]}; |
There was a problem hiding this comment.
Need the lazy eval. Second variable might be nil (but shouldn't be nil if first variable is true). This was done on purpose.
PabstMirror
reviewed
Dec 22, 2024
| } params ["_weapon", "_magazine"]; | ||
| private _magClass = configName _configMagazine; | ||
| private _weapons = [primaryWeapon EGVAR(arsenal,center), handgunWeapon EGVAR(arsenal,center)]; | ||
| private _weaponIndex = _weapons findIf {_x canAdd [_magClass, _x]}; |
There was a problem hiding this comment.
didn't know about weapon canAdd item syntax, neat
There was a problem hiding this comment.
New-ish. Was added around the same time as compatibleItems/Magazines weapon
PabstMirror
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When merged this pull request will:
IMPORTANT
Component - Add|Fix|Improve|Change|Make|Remove {changes}.