Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compat GM - Fix inheritance and add GM stringtable entries to display names #10256

Merged
merged 4 commits into from
Aug 26, 2024

Conversation

lambdatiger
Copy link
Contributor

@lambdatiger lambdatiger commented Aug 25, 2024

When merged this pull request will:

  • This PR fixes addresses an inheritance break in the previous version
  • Changes display names to GM's localization strings.

IMPORTANT

  • If the contribution affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
  • Development Guidelines are read, understood and applied.
  • Title of this PR uses our standard template Component - Add|Fix|Improve|Change|Make|Remove {changes}.

@lambdatiger lambdatiger changed the title GM Compat - Fix inheritance and add GM stringtable entries to display names Compat GM - Fix inheritance and add GM stringtable entries to display names Aug 25, 2024
@lambdatiger
Copy link
Contributor Author

https://github.com/lambdatiger/ace_frag-overhaul/blob/678ca56d7b7f4bc51cfd2bd8940fa5b5605342f4/addons/compat_gm/CfgVehicles.hpp#L131
Something I'd be interested in including is changing half of these to the 5.45x39 ammo box as most GM NVA units use 5.45 for their rifles and 7.62 being for automatic rifles and border guards. Although maybe that comes to a separate PR

@lambdatiger lambdatiger marked this pull request as ready for review August 25, 2024 02:42
@PabstMirror PabstMirror added this to the 3.18.0 milestone Aug 25, 2024
@PabstMirror PabstMirror added the kind/bug-fix Release Notes: **FIXED:** label Aug 25, 2024
@lambdatiger
Copy link
Contributor Author

Sorry, one of my formatting check scripts added the backslashes that aren't needed/don't reflect the original

@johnb432
Copy link
Contributor

https://github.com/lambdatiger/ace_frag-overhaul/blob/678ca56d7b7f4bc51cfd2bd8940fa5b5605342f4/addons/compat_gm/CfgVehicles.hpp#L131 Something I'd be interested in including is changing half of these to the 5.45x39 ammo box as most GM NVA units use 5.45 for their rifles and 7.62 being for automatic rifles and border guards. Although maybe that comes to a separate PR

This isn't the proper place to discuss it, but the reason why I added those is because the box specifically has M43 printed on it, which is 7.62x39.

@PabstMirror PabstMirror merged commit 18bd1ac into acemod:master Aug 26, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug-fix Release Notes: **FIXED:**
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants