Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dubious comparison in fnc_getDoorTurrets #5159

Closed
LordGolias opened this issue May 13, 2017 · 1 comment
Closed

Dubious comparison in fnc_getDoorTurrets #5159

LordGolias opened this issue May 13, 2017 · 1 comment
Assignees
Labels
Milestone

Comments

@LordGolias
Copy link
Contributor

LordGolias commented May 13, 2017

Hi guys and thank you for this great mod.

In ACE3-3.9.1, common/functions/fnc_getDoorTurrets.sqf line 26, we read

if (getNumber (_config >> "isCopilot" == 0) && {count getArray (_config >> "weapons") > 0}) then {
        _doorTurrets pushBack _x;
    };

I believe it should read

if (getNumber (_config >> "isCopilot") == 0 && {count getArray (_config >> "weapons") > 0}) then {
        _doorTurrets pushBack _x;
    };

as _config >> "isCopilot" == 0 does not make sense.

This was found while I was testing the SQF parser in the ACE base code.

@commy2
Copy link
Contributor

commy2 commented May 13, 2017

Based on this I'd say ACE_common_fnc_getDoorTurrets should fail every time with a script error.
I will test that.

@commy2 commy2 self-assigned this May 13, 2017
@commy2 commy2 added this to the 3.10.0 milestone May 13, 2017
@commy2 commy2 assigned PabstMirror and unassigned commy2 May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants