Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unify nodejs client #64

Closed
wants to merge 1 commit into from
Closed

Unify nodejs client #64

wants to merge 1 commit into from

Conversation

acelyc111
Copy link
Owner

What problem does this PR solve?

What is changed and how does it work?

Checklist

Tests
  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No code
Code changes
  • Has exported function/method change
  • Has exported variable/fields change
  • Has interface methods change
  • Has persistent data change
Side effects
  • Possible performance regression
  • Increased code complexity
  • Breaking backward compatibility
Related changes
  • Need to cherry-pick to the release branch
  • Need to update the documentation
  • Need to be included in the release note

@acelyc111 acelyc111 changed the base branch from master to DSN_DEFINE_int32 January 28, 2023 09:45
@github-actions github-actions bot removed the cpp label Jan 28, 2023
@acelyc111 acelyc111 force-pushed the unify_nodejs_client branch 2 times, most recently from 0516ce6 to a48167c Compare January 29, 2023 05:58
@github-actions github-actions bot added the cpp label Jan 29, 2023
@acelyc111 acelyc111 changed the base branch from DSN_DEFINE_int32 to master January 29, 2023 06:02
@github-actions github-actions bot removed the cpp label Jan 29, 2023
github-actions[bot]
github-actions bot reviewed Jan 29, 2023
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

license-eye has totally checked 1657 files.

Valid Invalid Ignored Fixed
1025 4 628 0
Click to see the invalid file list
  • nodejs-client/src/dsn/dsn.layer2_types.js
  • nodejs-client/src/dsn/meta.js
  • nodejs-client/src/dsn/rrdb.js
  • nodejs-client/src/dsn/rrdb_types.js

nodejs-client/src/dsn/dsn.layer2_types.js Outdated Show resolved Hide resolved
nodejs-client/src/dsn/meta.js Outdated Show resolved Hide resolved
nodejs-client/src/dsn/rrdb.js Outdated Show resolved Hide resolved
nodejs-client/src/dsn/rrdb_types.js Outdated Show resolved Hide resolved
@acelyc111 acelyc111 force-pushed the unify_nodejs_client branch 3 times, most recently from 438e272 to 2de7349 Compare January 29, 2023 07:09
@acelyc111 acelyc111 force-pushed the unify_nodejs_client branch from 2de7349 to 54313c1 Compare January 30, 2023 03:22
@acelyc111 acelyc111 closed this Jan 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

Assignees
No one assigned
Labels
nodejs-client scripts thrift
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@acelyc111