Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@accounts/password] Calling password.addEmail now trigger the email verification option #477

Merged
merged 1 commit into from
Oct 10, 2018

Conversation

pradel
Copy link
Member

@pradel pradel commented Oct 10, 2018

Calling addEmail on the server now trigger the validateEmail option.

@codecov
Copy link

codecov bot commented Oct 10, 2018

Codecov Report

Merging #477 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #477   +/-   ##
=======================================
  Coverage   95.79%   95.79%           
=======================================
  Files          57       57           
  Lines        1260     1260           
  Branches      172      173    +1     
=======================================
  Hits         1207     1207           
  Misses         50       50           
  Partials        3        3
Impacted Files Coverage Δ
packages/password/src/accounts-password.ts 92.68% <100%> (ø) ⬆️
packages/password/src/utils/is-email.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 241bdc2...186ebc9. Read the comment docs.

@pradel pradel merged commit 6372443 into master Oct 10, 2018
@pradel pradel deleted the feature/password-call-verify-email-options branch October 10, 2018 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants