Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add html email templates #403

Merged
merged 6 commits into from
Jul 23, 2018
Merged

Add html email templates #403

merged 6 commits into from
Jul 23, 2018

Conversation

lorensr
Copy link
Contributor

@lorensr lorensr commented Jul 22, 2018

I think it'll give a better idea to people of the existence of the option to have html if they see it printed to console or if they look at the code.

@pradel
Copy link
Member

pradel commented Jul 22, 2018

Good idea! can you please fix the EmailTemplateType type so the ci will pass? Thanks :)

@lorensr
Copy link
Contributor Author

lorensr commented Jul 23, 2018

Right, Typescript! Added the type, but CI still failing:

$ prettier --list-different '**/*.{json,md,js,ts}'
packages/server/src/utils/email.ts
error An unexpected error occurred: "Command failed.
Exit code: 1
Command: sh
Arguments: -c prettier --list-different '**/*.{json,md,js,ts}'
Directory: /home/circleci/project
Output:
".

When I run the command locally, I get:

image

@codecov
Copy link

codecov bot commented Jul 23, 2018

Codecov Report

Merging #403 into master will decrease coverage by 0.06%.
The diff coverage is 75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #403      +/-   ##
==========================================
- Coverage   95.52%   95.45%   -0.07%     
==========================================
  Files          57       57              
  Lines        1250     1254       +4     
  Branches      175      176       +1     
==========================================
+ Hits         1194     1197       +3     
- Misses         53       54       +1     
  Partials        3        3
Impacted Files Coverage Δ
packages/server/src/accounts-server.ts 90.05% <0%> (-0.51%) ⬇️
packages/server/src/utils/email.ts 85.71% <100%> (+3.89%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e869ae3...2fe85f6. Read the comment docs.

@pradel pradel merged commit 8221dde into accounts-js:master Jul 23, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants