Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apollo-link-accounts types #382

Merged
merged 1 commit into from
Jul 12, 2018
Merged

Fix apollo-link-accounts types #382

merged 1 commit into from
Jul 12, 2018

Conversation

pradel
Copy link
Member

@pradel pradel commented Jul 12, 2018

Right now when we compile apollo-link-accounts we have this file (index.d.ts) which is generated and failing when you integrate it to your project.

import { AccountsClient } from '@accounts/client';
export declare const accountsLink: (accountsClient: AccountsClient) => import("../../../node_modules/apollo-link-context/node_modules/apollo-link/lib/link").ApolloLink;

after the fix:

import { ApolloLink } from 'apollo-link';
import { AccountsClient } from '@accounts/client';
export declare const accountsLink: (accountsClient: AccountsClient) => ApolloLink;

@codecov
Copy link

codecov bot commented Jul 12, 2018

Codecov Report

Merging #382 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #382   +/-   ##
=======================================
  Coverage   95.52%   95.52%           
=======================================
  Files          57       57           
  Lines        1251     1251           
  Branches      162      162           
=======================================
  Hits         1195     1195           
  Misses         53       53           
  Partials        3        3

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75c1e96...8c521ac. Read the comment docs.

@pradel pradel merged commit e62d0d8 into master Jul 12, 2018
@pradel pradel deleted the feature/apollo-link-fix branch July 12, 2018 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants