This repository has been archived by the owner on May 19, 2020. It is now read-only.
fix(README): grammar #195
Merged
fix(README): grammar #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jolanglinais
suggested changes
Oct 26, 2019
There was a problem hiding this comment.
You'll want to add a DCO (Developers Certificate of Originality) per the instructions:
Ensure you provide a DCO sign-off for your commits using the -s option of git commit. For more information see how this works.
Also you should create an issue in techdocs to track the same changes to all the repos so we have consistent README files.
Signed-off-by: Archit <[email protected]>
|
@irmerk Thanks for the review, I have update changes and added DCO |
|
A couple changes, also make sure to rebase and push back up, then this can be merged. |
jolanglinais
approved these changes
Oct 28, 2019
Signed-off-by: Archit <[email protected]>
|
@irmerk Done and Thanks for this |
|
@irmerk I have Updated all changes |
|
Thank You @irmerk |
|
Email [email protected] so I can track your shipping info for Hacktoberfest. |
|
Thank You @irmerk I will email now |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Archit [email protected]
I found some Improper word choice as well as Improper formatting for that I have made changes and corrected that so, now It will be easier for everyone to read.
Please Merge this