Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Storybook not working #13

Closed
median-man opened this issue Jun 11, 2019 · 0 comments
Closed

Storybook not working #13

median-man opened this issue Jun 11, 2019 · 0 comments

Comments

@median-man
Copy link
Contributor

Trying to build or use the npm scripts (build-storybook or storybook) fails while building. There is a problem with react scripts. This issue would suggest that react scripts should be upgraded to ^2.1.2 in order for storybook to work.

I've already got it working. PR will be opened for review.
median-man added a commit to median-man/chromextension that referenced this issue Jun 11, 2019
@median-man
Upgrade react-scripts version to 2.1.8
86d9fdf 
This commit updates react-scripts in order to fix issue where
Storybook does not run.

See issue accimeesterlin#13
median-man added a commit to median-man/chromextension that referenced this issue Jun 11, 2019
@median-man
Add window.ga stub to storybook (issue accimeesterlin#13)
bd682f1 
This change fixes errors when viewing components with references to
`window.ga` in Storybook by adding a stub to
`/.storybook/preview-head.html`.

Closes accimeesterlin#13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@median-man