Fixing VoiceOver Support #13
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e, and a default solution for default speech output if not active.
…n through the speak method. Also changed how VoiceOver.is_active checks the running process by using pgrep.
|
@ctoth, thoughts on merging this? It certainly seems useful for those of us that develop for the Mac. |
…d to osascript to avoid script injection. Also changed how Voiceover is determined to be active or not using pgrep.
|
Given that I have not found any other working solution, I am ready to merge this pull request if one of the repository owners approves the changes and can merge this. Hopefully some day we are able to find a better solution, however as it is, we will have to live with using apple script and the lag that comes with it until a better solution is found. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented two classes: VoiceOver, and SystemVoiceOver. The VoiceOver class leverages Apple Script to directly talk to the currently running instance of VoiceOver, where the SystemVoiceOver class uses NSSpeechSynthesizer to create a new instance of VoiceOver to be used when VoiceOver is inactive.