Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: switch to Hearth Components, remove Hearth, upgrade to Laravel 11 #2375

Merged
merged 12 commits into from
Dec 3, 2024

Conversation

greatislander
Copy link
Collaborator

@greatislander greatislander commented Nov 26, 2024

Replaces fluid-project/hearth with fluid-project/hearth-components. Upgrades to Laravel 11, and adds a health endpoint.

Prerequisites

If this PR changes PHP code or dependencies:

  • I've run composer format and fixed any code formatting issues.
  • I've run composer analyze and addressed any static analysis issues.
  • I've run php artisan test and ensured that all tests pass.
  • I've run composer localize to update localization source files and committed any changes.

If this PR changes CSS or JavaScript code or dependencies:

  • I've run npm run lint and fixed any linting issues.
  • I've run npm run build and ensured that CSS and JavaScript assets can be compiled.

Copy link

codecov bot commented Nov 26, 2024

Codecov Report

Attention: Patch coverage is 81.81818% with 14 lines in your changes missing coverage. Please review.

Project coverage is 97.25%. Comparing base (2d1999f) to head (6802ad5).
Report is 33 commits behind head on dev.

Files with missing lines Patch % Lines
app/Rules/Password.php 12.50% 7 Missing ⚠️
app/Models/Individual.php 0.00% 2 Missing ⚠️
app/Models/MatchingStrategy.php 33.33% 2 Missing ⚠️
app/Models/Organization.php 0.00% 2 Missing ⚠️
...pp/Http/Responses/FailedTwoFactorLoginResponse.php 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev    #2375      +/-   ##
============================================
+ Coverage     96.93%   97.25%   +0.32%     
- Complexity     2212     2290      +78     
============================================
  Files           345      345              
  Lines         10393    10403      +10     
============================================
+ Hits          10074    10117      +43     
+ Misses          319      286      -33     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@greatislander greatislander linked an issue Dec 1, 2024 that may be closed by this pull request
@greatislander greatislander marked this pull request as ready for review December 1, 2024 19:16
@greatislander greatislander self-assigned this Dec 1, 2024
@greatislander greatislander added the enhancement New feature or request label Dec 1, 2024
@greatislander greatislander added this to the 1.6.0 milestone Dec 1, 2024
This was linked to issues Dec 1, 2024
Copy link
Collaborator

@jobara jobara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greatislander below are things I think still need to be updated:

  • update .gitignore to replace /resources/lang/vendor/hearth/lsq with resources/lang/vendor/hearth-components/lsq
  • update crowdin.yml to replace hearth with hearth-components
  • update ide.json to replace hearth with hearth-components
  • can hearth.php be removed?
  • many instances of <x-hearth-...> components in the blade templates. Should these be replaced with references to <x-hearth-components...?

@greatislander greatislander enabled auto-merge (squash) December 3, 2024 16:27
@greatislander greatislander merged commit 0ea8da0 into dev Dec 3, 2024
8 checks passed
@greatislander greatislander deleted the feat/laravel-11 branch December 3, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Upgrade to Pest v3 Upgrade to Laravel 11 Idea: add health check to admin
2 participants