-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: switch to Hearth Components, remove Hearth, upgrade to Laravel 11 #2375
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #2375 +/- ##
============================================
+ Coverage 96.93% 97.25% +0.32%
- Complexity 2212 2290 +78
============================================
Files 345 345
Lines 10393 10403 +10
============================================
+ Hits 10074 10117 +43
+ Misses 319 286 -33 ☔ View full report in Codecov by Sentry. |
af87400
to
4f2b96a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@greatislander below are things I think still need to be updated:
- update .gitignore to replace
/resources/lang/vendor/hearth/lsq
withresources/lang/vendor/hearth-components/lsq
- update crowdin.yml to replace hearth with hearth-components
- update ide.json to replace hearth with hearth-components
- can hearth.php be removed?
- many instances of
<x-hearth-...>
components in the blade templates. Should these be replaced with references to<x-hearth-components...
?
Replaces
fluid-project/hearth
withfluid-project/hearth-components
. Upgrades to Laravel 11, and adds a health endpoint.Prerequisites
If this PR changes PHP code or dependencies:
composer format
and fixed any code formatting issues.composer analyze
and addressed any static analysis issues.php artisan test
and ensured that all tests pass.composer localize
to update localization source files and committed any changes.If this PR changes CSS or JavaScript code or dependencies:
npm run lint
and fixed any linting issues.npm run build
and ensured that CSS and JavaScript assets can be compiled.